Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disabled PlzDedicatedWorker in Electron #233175

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −0
Open

fix: disabled PlzDedicatedWorker in Electron #233175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a862ad
fix: disabled PlzDedicatedWorker in Electron
pankajk07 Nov 6, 2024
946a6b7
Merge branch 'main' into pankajk07-patch-1
pankajk07 Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ if (args['sandbox'] &&
app.commandLine.appendSwitch('disable-gpu-sandbox');
}

// Fix for #233060, the following changes were suggested by the electron team here https://github.com/electron/electron/issues/43556#issuecomment-2345647103
app.commandLine.appendSwitch('disable-features', 'PlzDedicatedWorker');

// Set userData path before app 'ready' event
const userDataPath = getUserDataPath(args, product.nameShort ?? 'code-oss-dev');
if (process.platform === 'win32') {
Expand Down