Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add header filtering to query result grid #18373

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
+1,225 −976
Open

Add header filtering to query result grid #18373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
92fe1ba
wip working filter, needs styling
cssuh Nov 7, 2024
973e28d
loc files
cssuh Nov 7, 2024
ff93aff
track activepopup correctly
cssuh Nov 7, 2024
e44e376
add search field
cssuh Nov 7, 2024
114ad37
styling updates
cssuh Nov 7, 2024
3888bf2
select all checkbox
cssuh Nov 8, 2024
7925c7b
loc files
cssuh Nov 8, 2024
c10c2a7
fix build
cssuh Nov 11, 2024
276f5b9
wip, remove selected counter for now
cssuh Nov 11, 2024
81dbf95
apply themes
cssuh Nov 11, 2024
a3a1852
add primary button styling
cssuh Nov 11, 2024
f18c380
Merge branch 'main' into chsuh/filter
cssuh Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,477 changes: 687 additions & 790 deletions localization/l10n/bundle.l10n.json
View file
Open in desktop

Large diffs are not rendered by default.

15 changes: 15 additions & 0 deletions localization/xliff/vscode-mssql.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
<trans-unit id="++CODE++0d7668d337e375d8ccfc1a69ca8f6e22a0b0c850a78c4770b0c4aa3b0daca630">
<source xml:lang="en">&lt;default&gt;</source>
</trans-unit>
<trans-unit id="++CODE++77a16e7273815789a7843cb03066b381056176686bb37bc1505adddb490904bf">
<source xml:lang="en">0 Selected</source>
</trans-unit>
<trans-unit id="++CODE++08fef8ce26bbc554c749504c8d169642c3039345674331079add345b808e96a7">
<source xml:lang="en">A SQL editor must have focus before executing this command</source>
</trans-unit>
Expand Down Expand Up @@ -73,6 +76,9 @@
<trans-unit id="++CODE++0f67514b901da8b9c613167848294cb0010b3c0e696732aa1a0c9737e5be69b1">
<source xml:lang="en">And</source>
</trans-unit>
<trans-unit id="++CODE++31e392d1c0378beca611de66c0f4c71cba29159905cc54242d9bddee5b23d851">
<source xml:lang="en">Apply</source>
</trans-unit>
<trans-unit id="++CODE++3d283f80f43f1833dcab882ad9efc24a86c0b17b0febb10fc37336590a7016e1">
<source xml:lang="en">Are you sure you want to disconnect?</source>
</trans-unit>
Expand Down Expand Up @@ -135,6 +141,9 @@
<trans-unit id="++CODE++c1ea3f5e7aa473034872296473c7fcf9c79344355ba4fd003120627f6ec1a5f7">
<source xml:lang="en">Between</source>
</trans-unit>
<trans-unit id="++CODE++79654f98221029c4c838b279ed9a41aa49c8a3cdb1cc95d81a456c510e6854d0">
<source xml:lang="en">Blanks</source>
</trans-unit>
<trans-unit id="++CODE++221cedb44469e4b0b105f777c771d70c7097c40a4e3e914cec4b6ba266db1970">
<source xml:lang="en">Browse Azure</source>
</trans-unit>
Expand Down Expand Up @@ -759,6 +768,9 @@
<trans-unit id="++CODE++1359626e7b6964345896285446db7977e67469251bb0cc52808db2a85ed940c1">
<source xml:lang="en">Move Up</source>
</trans-unit>
<trans-unit id="++CODE++fb329000228cc5a24c264c57139de8bf854fc86fc18bf1c04ab61a2b5cb4b921">
<source xml:lang="en">NULL</source>
</trans-unit>
<trans-unit id="++CODE++dcd1d5223f73b3a965c07e3ff5dbee3eedcfedb806686a05b9b3868a2c3d6d50">
<source xml:lang="en">Name</source>
</trans-unit>
Expand Down Expand Up @@ -1070,6 +1082,9 @@
<trans-unit id="++CODE++f6a9305d2a22223e43e016e6ed4d342a8a4a249c1202322338ee3e0d5f26e596">
<source xml:lang="en">Script copied to clipboard</source>
</trans-unit>
<trans-unit id="++CODE++7f55382219f0202c1b4f56deb099e2fedcec87ee73fe2edb2105df5447323bc6">
<source xml:lang="en">Search...</source>
</trans-unit>
<trans-unit id="++CODE++d1ec69e64b9609d089aae09f7adc5c566d2cd222f8d8325f0ab3b523f0ac2690">
<source xml:lang="en">Select All</source>
</trans-unit>
Expand Down
6 changes: 6 additions & 0 deletions src/reactviews/common/locConstants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,12 @@ export class LocConstants {
copy: l10n.t("Copy"),
copyWithHeaders: l10n.t("Copy with Headers"),
copyHeaders: l10n.t("Copy Headers"),
null: l10n.t("NULL"),
blankString: l10n.t("Blanks"),
apply: l10n.t("Apply"),
clear: l10n.t("Clear"),
search: l10n.t("Search..."),
selected: l10n.t("0 Selected"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is this shown? My gut says that this either ought to be "{num} selected" or "None selected" (word rather than number for the special "zero-case" feels nicer here to me?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is only shown when none are selected, then the var name should be noneSelected or zeroSelected instead of selected

};
}
}
Expand Down
Loading
Loading