Fix two bugs with trusted compiler paths #11998
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs with trusted compiler paths:
It's intended that the
compilerPathfield inc_cpp_properties.jsonand theC_Cpp.default.compilerPathmay actually contain a full command line with compiler arguments. This allows arguments to be specified that contain shell escaping, whereas thecompilerArgsarray does/must not have shell escaping. This change fixes an issue where the unprocessed compiler path was being passed to the native process, without having yet stripped the compiler args from it, if present. (Note that it may now redundantly provide the same trusted compiler in other scenario, which that shouldn't cause an issue.)Fixes an issue where, if the native process were to crash, it would not be properly provided the trusted compiler from the base configuration. (It's possible there may still be an issue here related to custom config providers, as custom file and browse configs would need to again be provided to the restarted native process again, and it's unclear to me if that's happening).