Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lldb-mi commit hash #11566

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bump lldb-mi commit hash #11566

wants to merge 2 commits into from

Conversation

ylatuya
Copy link

@ylatuya ylatuya commented Oct 23, 2023

Fix #6874

@WardenGnaw
Copy link
Member

WardenGnaw commented Oct 24, 2023

This alone wont upgrade the version of lldb-mi used. Someone will need to re-run the internal lldb-mi and update the release.

@bobbrow
Copy link
Member

bobbrow commented Nov 3, 2023

This alone wont upgrade the version of lldb-mi used. Someone will need to re-run the internal lldb-mi and update the release.

Will you be able to do that @WardenGnaw?

@WardenGnaw
Copy link
Member

Theres a couple issues that I do not have the cycles to fix.

  1. cpptoolsMacM1pool seems to have been removed and lldb-mi.template.yml fails to build LLVM on the public macos-13-arm64
  2. 0d44201451f03ba907cdb268ddddfc3fa38a0ebd seems to be too old for macos-latest and is failing to build for x64 lldb-mi.

@ylatuya Were you able to build lldb-mi locally with LLVM commit 0d44201451f03ba907cdb268ddddfc3fa38a0ebd?

@ylatuya
Copy link
Author

ylatuya commented Nov 11, 2023

@ylatuya Were you able to build lldb-mi locally with LLVM commit 0d44201451f03ba907cdb268ddddfc3fa38a0ebd?

To fix the lldb-mi bug, I built it using main, which at that time was at commit:

commit 296671f059198185bedc3eba80056ebf4bc7ad30 (HEAD -> main, origin/main, origin/HEAD)
Author: Nikita Popov <[email protected]>
Date:   Wed Sep 27 11:59:44 2023 +0200

    [LoopUnroll] Store more information in UnrollCostEstimator (NFCI)
    
    Instead of having ApproximateLoopSize() use a bunch of out parameters,
    from which we later construct an UnrollCostEstimator, directly
    construct UnrollCostEstimator which holds all the information
    derived from loop analysis. This makes it easier to add additional
    metrics in the future.

@H-G-Hristov
Copy link

H-G-Hristov commented Nov 15, 2023

@ylatuya Sorry for off-topic do you know how to fix this issue or how to approach fixing it: lldb-tools/lldb-mi#101
This renders debugging on macOS useless basically. And I wonder if it is related to your fix in anyway (or at least the other reprorted issues with cpptools).

@ylatuya
Copy link
Author

ylatuya commented Nov 15, 2023

@ylatuya Sorry for off-topic do you know how to fix this issue or how to approach fixing it: lldb-tools/lldb-mi#101 This renders debugging on macOS useless basically. And I wonder if it is related to your fix in anyway (or at least the other reprorted issues with cpptools).

I don't know how to fix it, sorry. This was my first contribution and it was a trivial fix.

@H-G-Hristov
Copy link

H-G-Hristov commented Jan 5, 2024

@ylatuya Sorry for off-topic do you know how to fix this issue or how to approach fixing it: lldb-tools/lldb-mi#101 This renders debugging on macOS useless basically. And I wonder if it is related to your fix in anyway (or at least the other reprorted issues with cpptools).

I don't know how to fix it, sorry. This was my first contribution and it was a trivial fix.

@ylatuya There seems to be a proposed fix for the memory leak issue. Could you please update this PR to the latest commit: a6c8c66 here: https://github.com/lldb-tools/lldb-mi/commits/main/

@WardenGnaw @bobbrow Is there any change updating this PR and moving it forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot debug on MacOS when long environment variable is set (circa 2000 characters)
5 participants