Enqueue the call to sendDidOpen #11337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearthecowboy
commented
Aug 17, 2023
| // reset the promise for the dispatcher | ||
| DefaultClient.dispatching.reset(); | ||
|
|
||
| do { | ||
| // ensure that this is OK to start working |
There was a problem hiding this comment.
It turns out that the dispatching can have stuff going when something crashes, so we move the check to inside the loop
bobbrow
approved these changes
Aug 17, 2023
sean-mcmanus
approved these changes
Aug 18, 2023
sean-mcmanus
pushed a commit
that referenced
this pull request
Aug 21, 2023
* enqueue the call to sendDidOpen
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #11335