[hpx] Adding support for HPX release v1.9.1 #33106

hkaiser · 2023-08-10T19:22:22Z

Changes comply with the maintainer guide
SHA512s are updated for each updated download
The "supports" clause reflects platforms that may be fixed by this new version
Any fixed CI baseline entries are removed from that file.
Any patches that are no longer applied are deleted from the port's directory.
The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
Only one version is added to each modified port's versions file.

ports/hpx/portfile.cmake

JonLiu1993 · 2023-08-11T09:40:05Z

@hkaiser, Thanks for your PR, this is error, please take look:

CMake Error at ports/hpx/portfile.cmake:94 (file):
  file RENAME failed to rename

    D:/packages/hpx_x64-windows/bin/hpxrun.py

  to

    D:/packages/hpx_x64-windows/tools/hpx/hpxrun.py

  because: The system cannot find the file specified.

JonLiu1993 · 2023-08-11T09:41:28Z

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

hkaiser · 2023-08-11T16:52:32Z

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

This should be fine now. Thanks!

JonLiu1993 · 2023-08-14T02:21:26Z

@hkaiser, There is one more bug that needs to be fixed:

D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\thread_pools\include\hpx\thread_pools\scheduled_thread_pool.hpp(107): note: see the first reference to 'hpx::threads::policies::shared_priority_queue_scheduler<std::mutex,hpx::threads::policies::concurrentqueue_fifo,hpx::threads::policies::default_shared_priority_queue_scheduler_terminated_queue>::get_thread_count' in 'hpx::threads::detail::scheduled_thread_pool<hpx::threads::policies::shared_priority_queue_scheduler<std::mutex,hpx::threads::policies::concurrentqueue_fifo,hpx::threads::policies::default_shared_priority_queue_scheduler_terminated_queue>>::get_thread_count'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(767): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(772): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(777): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(784): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): error C2672: 'hpx::bit_cast': no matching overloaded function found
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\type_support\include\hpx\type_support\bit_cast.hpp(34): note: could be 'enable_if<sizeof(To)==sizeof(From)&&std::is_trivially_copyable_v<From>&&std::is_trivially_copyable_v<To>,To>::type hpx::bit_cast(const From &) noexcept'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: Failed to specialize function template 'enable_if<sizeof(To)==sizeof(From)&&std::is_trivially_copyable_v<From>&&std::is_trivially_copyable_v<To>,To>::type hpx::bit_cast(const From &) noexcept'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: With the following template arguments:
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: 'To=Right *'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: 'From=uint64_t'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(93): note: while compiling class template member function 'Right *hpx::lockfree::tagged_ptr_pair<hpx::lockfree::deque_node<T>,Right>::extract_right_ptr(hpx::lockfree::tagged_ptr_pair<hpx::lockfree::deque_node<T>,Right>::compressed_ptr_pair_t) noexcept'

hkaiser · 2023-08-14T11:09:28Z

@hkaiser, There is one more bug that needs to be fixed:

D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\thread_pools\include\hpx\thread_pools\scheduled_thread_pool.hpp(107): note: see the first reference to 'hpx::threads::policies::shared_priority_queue_scheduler<std::mutex,hpx::threads::policies::concurrentqueue_fifo,hpx::threads::policies::default_shared_priority_queue_scheduler_terminated_queue>::get_thread_count' in 'hpx::threads::detail::scheduled_thread_pool<hpx::threads::policies::shared_priority_queue_scheduler<std::mutex,hpx::threads::policies::concurrentqueue_fifo,hpx::threads::policies::default_shared_priority_queue_scheduler_terminated_queue>>::get_thread_count'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(767): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(772): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(777): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\schedulers\include\hpx\schedulers\queue_holder_thread.hpp(784): warning C4244: 'return': conversion from 'int64_t' to 'size_t', possible loss of data
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): error C2672: 'hpx::bit_cast': no matching overloaded function found
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\type_support\include\hpx\type_support\bit_cast.hpp(34): note: could be 'enable_if<sizeof(To)==sizeof(From)&&std::is_trivially_copyable_v<From>&&std::is_trivially_copyable_v<To>,To>::type hpx::bit_cast(const From &) noexcept'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: Failed to specialize function template 'enable_if<sizeof(To)==sizeof(From)&&std::is_trivially_copyable_v<From>&&std::is_trivially_copyable_v<To>,To>::type hpx::bit_cast(const From &) noexcept'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: With the following template arguments:
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: 'To=Right *'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(96): note: 'From=uint64_t'
D:\buildtrees\hpx\src\v1.9.1-d67aefad9f.clean\libs\core\concurrency\include\hpx\concurrency\detail\tagged_ptr_pair.hpp(93): note: while compiling class template member function 'Right *hpx::lockfree::tagged_ptr_pair<hpx::lockfree::deque_node<T>,Right>::extract_right_ptr(hpx::lockfree::tagged_ptr_pair<hpx::lockfree::deque_node<T>,Right>::compressed_ptr_pair_t) noexcept'

@JonLiu1993 what compiler is that happening with?

Neumann-A · 2023-08-14T11:20:31Z

@hkaiser: VS2022 targeting x86.

hkaiser · 2023-08-14T12:26:20Z

@hkaiser: VS2022 targeting x86.

We currently do not really support 32bit builds (in particular on Windows). Is there a way to disable this on vcpkg? I have however opened a ticket (STEllAR-GROUP/hpx#6323) to have a look at this for the next release.

Neumann-A · 2023-08-14T12:28:38Z

add "supports": "!(windows & x86)" to the manifest

JonLiu1993 · 2023-08-15T07:00:00Z

@hkaiser, if this PR is ready for review please let me know.

hkaiser · 2023-08-15T11:40:40Z

@hkaiser, if this PR is ready for review please let me know.

@JonLiu1993 Yes, this is ready to go (at least the tests pass now). Thanks!

JonLiu1993 · 2023-08-16T06:00:00Z

@hkaiser, When I tested the usage by hpx:x64-windows I get this error, could you please take a look:

1> CMake generation started for configuration: 'x64-Debug'.
1> Command line: "C:\WINDOWS\system32\cmd.exe" /c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Visual Studio 17 2022" -A x64  -DCMAKE_CONFIGURATION_TYPES:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\test\source\repos\usageTest\out\install\x64-Debug" -DCMAKE_TOOLCHAIN_FILE=F:/Feature-test/vcpkg/scripts/buildsystems/vcpkg.cmake "C:\Users\test\source\repos\usageTest" 2>&1"
1> Working directory: C:\Users\test\source\repos\usageTest\out\build\x64-Debug
1> [CMake] -- Selecting Windows SDK version 10.0.22621.0 to target Windows 10.0.19045.
1> [CMake] CMake Error at F:/Feature-test/vcpkg/scripts/buildsystems/vcpkg.cmake:855 (_find_package):
1> [CMake]   By not providing "FindHPX.cmake" in CMAKE_MODULE_PATH this project has
1> [CMake]   asked CMake to find a package configuration file provided by "HPX", but
1> [CMake]   CMake did not find one.
1> [CMake] 
1> [CMake]   Could not find a package configuration file provided by "HPX" with any of
1> [CMake]   the following names:
1> [CMake] 
1> [CMake]     HPXConfig.cmake
1> [CMake]     hpx-config.cmake
1> [CMake] 
1> [CMake]   Add the installation prefix of "HPX" to CMAKE_PREFIX_PATH or set "HPX_DIR"
1> [CMake]   to a directory containing one of the above files.  If "HPX" provides a
1> [CMake]   separate development package or SDK, be sure it has been installed.
1> [CMake] Call Stack (most recent call first):
1> [CMake]   usageTest/CMakeLists.txt:5 (find_package)
1> [CMake] -- Configuring incomplete, errors occurred!
1> 'C:\WINDOWS\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Visual Studio 17 2022" -A x64  -DCMAKE_CONFIGURATION_TYPES:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\test\source\repos\usageTest\out\install\x64-Debug" -DCMAKE_TOOLCHAIN_FILE=F:/Feature-test/vcpkg/scripts/buildsystems/vcpkg.cmake "C:\Users\test\source\repos\usageTest" 2>&1"' execution failed with error: ''C:\WINDOWS\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Visual Studio 17 2022" -A x64  -DCMAKE_CONFIGURATION_TYPES:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\test\source\repos\usageTest\out\install\x64-Debug" -DCMAKE_TOOLCHAIN_FILE=F:/Feature-test/vcpkg/scripts/buildsystems/vcpkg.cmake "C:\Users\test\source\repos\usageTest" 2>&1"' returned with exit code: 1'.

Usage:

The port hpx provides CMake targets:

    find_package(HPX REQUIRED)
    target_link_libraries(main PRIVATE HPX::hpx)

CMakeLists.txt:

cmake_minimum_required (VERSION 3.8)

project(test)

find_package(HPX REQUIRED)

add_executable (test "usageTest.cpp")

target_link_libraries(test PRIVATE HPX::hpx)

usageTest.cpp:

#include <stdio.h>

int main()
{
    printf("%s\n", "HELLO WORLD");
    return 0;
}

CMakeSettings.json:

{
  "configurations": [
    {
      "name": "x64-Debug",
      "generator": "Visual Studio 17 2022 Win64",
      "configurationType": "Debug",
      "inheritEnvironments": [ "msvc_x64_x64" ],
      "buildRoot": "${projectDir}\\out\\build\\${name}",
      "installRoot": "${projectDir}\\out\\install\\${name}",
      "cmakeCommandArgs": "-DCMAKE_TOOLCHAIN_FILE=F:/Feature-test/vcpkg/scripts/buildsystems/vcpkg.cmake",
      "buildCommandArgs": "",
      "ctestCommandArgs": ""
    }
   ]
}

Neumann-A · 2023-08-16T06:12:18Z

@JonLiu1993 According to the file list: hpx:x64-windows:/share/hpx/HPXConfig.cmake there should be a config. Are you sure you have the correct triplet selected? (consider using manifest mode for usage testing.)

JonLiu1993 · 2023-08-17T08:09:47Z

Tested usage again by hpx:x64-windows successfully:

The port hpx provides CMake targets:

    find_package(HPX REQUIRED)
    target_link_libraries(main PRIVATE HPX::hpx)

config:

1> CMake generation started for configuration: 'x64-Debug'.
1> Command line: "C:\WINDOWS\system32\cmd.exe" /c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Visual Studio 17 2022" -A x64  -DCMAKE_CONFIGURATION_TYPES:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\test\source\repos\usageTest\out\install\x64-Debug" -DCMAKE_TOOLCHAIN_FILE=F:/Feature-test/hpx/vcpkg/scripts/buildsystems/vcpkg.cmake "C:\Users\test\source\repos\usageTest" 2>&1"
1> Working directory: C:\Users\test\source\repos\usageTest\out\build\x64-Debug
1> [CMake] -- Selecting Windows SDK version 10.0.22621.0 to target Windows 10.0.19045.
1> [CMake] -- The C compiler identification is MSVC 19.36.32538.0
1> [CMake] -- The CXX compiler identification is MSVC 19.36.32538.0
1> [CMake] -- Detecting C compiler ABI info
1> [CMake] -- Detecting C compiler ABI info - done
1> [CMake] -- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe - skipped
1> [CMake] -- Detecting C compile features
1> [CMake] -- Detecting C compile features - done
1> [CMake] -- Detecting CXX compiler ABI info
1> [CMake] -- Detecting CXX compiler ABI info - done
1> [CMake] -- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe - skipped
1> [CMake] -- Detecting CXX compile features
1> [CMake] -- Detecting CXX compile features - done
1> [CMake] -- Found Asio: F:/Feature-test/hpx/vcpkg/installed/x64-windows/include (found suitable version "1.28.0", minimum required is "1.12.0") 
1> [CMake] -- Using system allocator.
1> [CMake] -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
1> [CMake] -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
1> [CMake] -- Looking for pthread_create in pthreads
1> [CMake] -- Looking for pthread_create in pthreads - not found
1> [CMake] -- Looking for pthread_create in pthread
1> [CMake] -- Looking for pthread_create in pthread - not found
1> [CMake] -- Found Threads: TRUE  
1> [CMake] -- Found Boost: F:/Feature-test/hpx/vcpkg/installed/x64-windows/include (found suitable version "1.82.0", minimum required is "1.71")  
1> [CMake] CMake Warning at C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.26/Modules/FindBoost.cmake:1384 (message):
1> [CMake]   New Boost version may have incorrect or missing dependencies and imported
1> [CMake]   targets
1> [CMake] Call Stack (most recent call first):
1> [CMake]   C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.26/Modules/FindBoost.cmake:1508 (_Boost_COMPONENT_DEPENDENCIES)
1> [CMake]   C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.26/Modules/FindBoost.cmake:2119 (_Boost_MISSING_DEPENDENCIES)
1> [CMake]   F:/Feature-test/hpx/vcpkg/installed/x64-windows/share/boost/vcpkg-cmake-wrapper.cmake:11 (_find_package)
1> [CMake]   F:/Feature-test/hpx/vcpkg/scripts/buildsystems/vcpkg.cmake:809 (include)
1> [CMake]   F:/Feature-test/hpx/vcpkg/installed/x64-windows/share/hpx/HPX_SetupBoostIostreams.cmake:12 (find_package)
1> [CMake]   F:/Feature-test/hpx/vcpkg/installed/x64-windows/share/hpx/HPXConfig.cmake:138 (include)
1> [CMake]   F:/Feature-test/hpx/vcpkg/scripts/buildsystems/vcpkg.cmake:855 (_find_package)
1> [CMake]   usageTest/CMakeLists.txt:5 (find_package)
1> [CMake] 
1> [CMake] 
1> [CMake] CMake Warning at C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.26/Modules/FindBoost.cmake:1384 (message):
1> [CMake]   New Boost version may have incorrect or missing dependencies and imported
1> [CMake]   targets
1> [CMake] Call Stack (most recent call first):
1> [CMake]   C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.26/Modules/FindBoost.cmake:1508 (_Boost_COMPONENT_DEPENDENCIES)
1> [CMake]   C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.26/Modules/FindBoost.cmake:2119 (_Boost_MISSING_DEPENDENCIES)
1> [CMake]   F:/Feature-test/hpx/vcpkg/installed/x64-windows/share/boost/vcpkg-cmake-wrapper.cmake:11 (_find_package)
1> [CMake]   F:/Feature-test/hpx/vcpkg/scripts/buildsystems/vcpkg.cmake:809 (include)
1> [CMake]   F:/Feature-test/hpx/vcpkg/installed/x64-windows/share/hpx/HPX_SetupBoostIostreams.cmake:12 (find_package)
1> [CMake]   F:/Feature-test/hpx/vcpkg/installed/x64-windows/share/hpx/HPXConfig.cmake:138 (include)
1> [CMake]   F:/Feature-test/hpx/vcpkg/scripts/buildsystems/vcpkg.cmake:855 (_find_package)
1> [CMake]   usageTest/CMakeLists.txt:5 (find_package)
1> [CMake] 
1> [CMake] 
1> [CMake] -- Found Boost: F:/Feature-test/hpx/vcpkg/installed/x64-windows/include (found suitable version "1.82.0", minimum required is "1.71") found components: iostreams regex 
1> [CMake] --   iostreams
1> [CMake] -- Found Hwloc: F:/Feature-test/hpx/vcpkg/installed/x64-windows/debug/lib/hwloc.lib  
1> [CMake] -- The CUDA compiler identification is NVIDIA 11.7.64
1> [CMake] -- Detecting CUDA compiler ABI info
1> [CMake] -- Detecting CUDA compiler ABI info - done
1> [CMake] -- Check for working CUDA compiler: C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v11.7/bin/nvcc.exe - skipped
1> [CMake] -- Detecting CUDA compile features
1> [CMake] -- Detecting CUDA compile features - done
1> [CMake] -- Found CUDAToolkit: C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v11.7/include (found version "11.7.64") 
1> [CMake] -- Checking for module 'mpi-cxx'
1> [CMake] --   Package 'mpi-cxx', required by 'virtual:world', not found
1> [CMake] -- MPI version:  2.0
1> [CMake] -- Configuring done (37.6s)
1> [CMake] -- Generating done (0.1s)
1> [CMake] -- Build files have been written to: C:/Users/test/source/repos/usageTest/out/build/x64-debug
1> Extracted CMake variables.
1> Extracted source files and headers.
1> Extracted code model.
1> Extracted toolchain configurations.
1> Extracted includes paths.
1> CMake generation finished.

build:

>------ Build All started: Project: usageTest, Configuration: x64-Debug ------
  MSBuild version 17.6.3+07e294721 for .NET Framework
  
    Checking Build System
    Building Custom Rule C:/Users/test/source/repos/usageTest/usageTest/CMakeLists.txt
    usageTest.cpp
    The header hpx/affinity.hpp is deprecated, please include hpx/modules/affinity.hpp instead.To disable this warning, please define HPX_HAVE_DEPRECATION_WARNINGS=0.
       Creating library C:/Users/test/source/repos/usageTest/out/build/x64-debug/usageTest/Debug/test.lib and object C:/Users/test/source/repos/usageTest/out/build/x64-debug/usageTest/Debug/test.exp
    test.vcxproj -> C:\Users\test\source\repos\usageTest\out\build\x64-debug\usageTest\Debug\test.exe
    Building Custom Rule C:/Users/test/source/repos/usageTest/CMakeLists.txt

Build All succeeded.

Neumann-A reviewed Aug 10, 2023

View reviewed changes

ports/hpx/portfile.cmake Outdated Show resolved Hide resolved

Neumann-A reviewed Aug 10, 2023

View reviewed changes

ports/hpx/portfile.cmake Outdated Show resolved Hide resolved

hkaiser force-pushed the hpx_1.9.1 branch 2 times, most recently from a9bfe88 to 0eaa722 Compare August 10, 2023 20:26

Cheney-W assigned JonLiu1993 Aug 11, 2023

JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 11, 2023

JonLiu1993 marked this pull request as draft August 11, 2023 09:40

hkaiser force-pushed the hpx_1.9.1 branch from 0eaa722 to a5e386a Compare August 11, 2023 16:52

hkaiser marked this pull request as ready for review August 11, 2023 16:52

JonLiu1993 marked this pull request as draft August 14, 2023 02:21

hkaiser mentioned this pull request Aug 14, 2023

Fix 32bit Windows build STEllAR-GROUP/hpx#6323

Open

Adding support for HPX release v1.9.1

9c64518

hkaiser force-pushed the hpx_1.9.1 branch from a5e386a to 9c64518 Compare August 14, 2023 14:30

hkaiser marked this pull request as ready for review August 15, 2023 11:40

JonLiu1993 marked this pull request as draft August 16, 2023 06:00

JonLiu1993 marked this pull request as ready for review August 17, 2023 08:05

JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Aug 17, 2023

dan-shaw merged commit cf37b65 into microsoft:master Aug 17, 2023
15 checks passed

hkaiser deleted the hpx_1.9.1 branch August 19, 2023 15:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[hpx] Adding support for HPX release v1.9.1 #33106

[hpx] Adding support for HPX release v1.9.1 #33106

hkaiser commented Aug 10, 2023

JonLiu1993 commented Aug 11, 2023

JonLiu1993 commented Aug 11, 2023

hkaiser commented Aug 11, 2023

JonLiu1993 commented Aug 14, 2023

hkaiser commented Aug 14, 2023

Neumann-A commented Aug 14, 2023

hkaiser commented Aug 14, 2023

Neumann-A commented Aug 14, 2023

JonLiu1993 commented Aug 15, 2023

hkaiser commented Aug 15, 2023

JonLiu1993 commented Aug 16, 2023

Neumann-A commented Aug 16, 2023

JonLiu1993 commented Aug 17, 2023

[hpx] Adding support for HPX release v1.9.1 #33106

[hpx] Adding support for HPX release v1.9.1 #33106

Conversation

hkaiser commented Aug 10, 2023

JonLiu1993 commented Aug 11, 2023

JonLiu1993 commented Aug 11, 2023

hkaiser commented Aug 11, 2023

JonLiu1993 commented Aug 14, 2023

hkaiser commented Aug 14, 2023

Neumann-A commented Aug 14, 2023

hkaiser commented Aug 14, 2023

Neumann-A commented Aug 14, 2023

JonLiu1993 commented Aug 15, 2023

hkaiser commented Aug 15, 2023

JonLiu1993 commented Aug 16, 2023

Neumann-A commented Aug 16, 2023

JonLiu1993 commented Aug 17, 2023