Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish "Implement depend-defaults" #538

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Finish "Implement depend-defaults" #538

wants to merge 25 commits into from

Conversation

autoantwort
Copy link
Contributor

@autoantwort autoantwort commented May 10, 2022 •
edited by ras0219-msft
Loading

edit by @ras0219-msft: Original PR at #295

@autoantwort autoantwort mentioned this pull request May 11, 2022
Closed
@autoantwort autoantwort changed the title get pipeline results Finish "Implement depend-defaults" May 12, 2022
@autoantwort autoantwort marked this pull request as ready for review May 12, 2022 17:00
@autoantwort
Merge branch 'main' into dev/roschuma/depends-defaults
d041774 
# Conflicts:
#	include/vcpkg/dependencies.h
#	src/vcpkg-test/dependencies.cpp
#	src/vcpkg-test/manifests.cpp
#	src/vcpkg/install.cpp
#	src/vcpkg/packagespec.cpp
#	src/vcpkg/sourceparagraph.cpp
@autoantwort
Merge branch 'main' into dev/roschuma/depends-defaults
53bcd53 
# Conflicts:
#	src/vcpkg/sourceparagraph.cpp
@autoantwort
Fix null pointer access
5d786d3
@autoantwort
Ignore default feature when checking if it is installed
17f4abd
@dg0yt dg0yt mentioned this pull request Jan 7, 2023
Open
@autoantwort autoantwort mentioned this pull request May 6, 2023
Open
@autoantwort
WIP: Merge branch 'main' into dev/roschuma/depends-defaults
fcb6fa2 
# Conflicts:
#	include/vcpkg/dependencies.h
#	include/vcpkg/packagespec.h
#	src/vcpkg-test/dependencies.cpp
#	src/vcpkg-test/manifests.cpp
#	src/vcpkg/commands.install.cpp
#	src/vcpkg/dependencies.cpp
#	src/vcpkg/packagespec.cpp
#	src/vcpkg/sourceparagraph.cpp
@autoantwort
Fix build after Merge with main
63c4074
@autoantwort
Fix tests
d40fcb0
@autoantwort
Remove unnecessary change
5114b65
@autoantwort
Copy link
Contributor Author

@ras0219-msft Since #813 was merged I merged with main. I have changed the implementation so that a Dependency is still context free. The downsite is that the parser is now not context free anymore, but we have to decide if a Dependency xor the parser should be context free or not (I personally prefer to have a context free description of a Dependency). I can change the code so that it is the other way around my making the default_features member of the Dependency an Optional<bool>.

@autoantwort autoantwort mentioned this pull request Aug 5, 2023
Draft
@autoantwort
Copy link
Contributor Author

autoantwort commented Aug 5, 2023 •
edited
Loading

For the documentation I have created microsoft/vcpkg-docs#119

@silverqx
Copy link

silverqx commented Sep 5, 2023

So much effort invested in this and no reviews or merges, I would like to see this merged if the PR is correct and working with big packages like qtbase or qt5-base.

@autoantwort
Merge branch 'main' into dev/roschuma/depends-defaults
95e132c 
# Conflicts:
#	src/vcpkg/sourceparagraph.cpp
@autoantwort
Copy link
Contributor Author

@ras0219-msft This is open since nearly 1.5 years. Do you have an update? :)

@autoantwort
Merge branch 'main' into dev/roschuma/depends-defaults
e045dd1 
# Conflicts:
#	include/vcpkg/sourceparagraph.h
#	src/vcpkg-test/manifests.cpp
@dg0yt dg0yt mentioned this pull request Jan 26, 2024
Open
@Arech
Copy link

Arech commented Jan 29, 2024

Dear stakeholders, any progress on that?
This issue with ignoring default-features:false is a major source of pain for the development due to frequent unnecessary rebuilds. Also vcpkg CI doesn't cover some platforms at all such as QNX; lots of ports are buggy there and having minimal builds are the must..

@autoantwort
Merge branch 'main' into dev/roschuma/depends-defaults
d71b3e4
@autoantwort
More merge conflicts
9befbe2
@autoantwort
Merge branch 'main' into dev/roschuma/depends-defaults
4cf4f3a 
# Conflicts:
#	include/vcpkg/dependencies.h
#	src/vcpkg-test/dependencies.cpp
#	src/vcpkg-test/plan.cpp
#	src/vcpkg/commands.install.cpp
#	src/vcpkg/dependencies.cpp
@JavierMatosD JavierMatosD added the requires:vcpkg-team-review This PR or issue requires someone from the vcpkg team to take a further look. label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft left review comments

@silverqx silverqx silverqx left review comments

Assignees
No one assigned
Labels
requires:vcpkg-team-review This PR or issue requires someone from the vcpkg team to take a further look.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@autoantwort @silverqx @Arech @ras0219-msft @JavierMatosD