[scripts/posh-vcpkg] Change TabExpansion to Register-ArgumentCompleter #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiting PRTest case passed
The symbol
|
WangWeiLin-MV
force-pushed
the
scripts/posh-vcpkg
branch
8 times, most recently
from
5ff6ef7
to
dced1f3
Compare
WangWeiLin-MV
force-pushed
the
scripts/posh-vcpkg
branch
7 times, most recently
from
44690ed
to
1f43818
Compare
WangWeiLin-MV
force-pushed
the
scripts/posh-vcpkg
branch
7 times, most recently
from
d79fdb2
to
0eba246
Compare
WangWeiLin-MV
commented
Nov 8, 2024
scripts/posh-vcpkg.psm1
Outdated
Comment on lines
28
to
37
| [PowerShell]$cmd = [PowerShell]::Create().AddCommand($commandText).AddParameters( | ||
| @('autocomplete') + $textsBeforeCursor + $spaceToComplete | ||
| ) | ||
| } | ||
|
|
||
| Export-ModuleMember @exportModuleMemberParams | ||
| [string[]]$completions = $cmd.Invoke() | ||
|
|
||
| if ($cmd.HadErrors -or $completions.Count -eq 0) { | ||
| return @() | ||
| } |
There was a problem hiding this comment.
Prevent vcpkg errors passing to user shell
vcpkg autocomplete install --tripleterror: the option 'triplet' requires a value
e14a7c2
to
fb13f71
Compare
WangWeiLin-MV
force-pushed
the
scripts/posh-vcpkg
branch
11 times, most recently
from
686cb63
to
c56f17d
Compare
WangWeiLin-MV
force-pushed
the
scripts/posh-vcpkg
branch
from
c56f17d
to
3eb6c32
Compare
WangWeiLin-MV
force-pushed
the
scripts/posh-vcpkg
branch
from
3eb6c32
to
4140534
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for microsoft/vcpkg#38184
The function
TabExpansionis not supported by PowerShell 7.4.0, which breaks theposh-vcpkg.psm1forvcpkg integrate powershell.Use
Register-ArgumentCompleterinstead ofTabExpansionto fix it.Change
posh-vcpkgmodule to non-version directoryposh-vcpkg.psd1minimum version from 5.0 to 5.1TabExpansionwithRegister-ArgumentCompleterend-to-end-tests-dir/autocomplete-posh-vcpkg.ps1e2e-specs/autocomplete-posh-vcpkg.Tests.ps1Test
Test passes locally on
7.4.2with Pester5.6.1on Linux7.4.3with Pester5.6.1on macOS7.4.6with Pester5.6.1on Windows5.1with Pester5.6.1on WindowsCorePowerShell/issues/2912