-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overlooked overload information on torchlib functions #919
Conversation
[ghstack-poisoned]
[ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## main #919 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 112 112
Lines 13547 13547
Branches 1377 1377
=======================================
Hits 10406 10406
Misses 2798 2798
Partials 343 343
|
Are these all of them? I can start working on refactor |
Updating with latest bench log. |
Fixes #865 [ghstack-poisoned]
Maybe the rounding mode didn't affect things much? |
Maybe. Maybe type promotion does the right thing for it. Maybe I think if |
@justinchuby do you know if |
No. It started to fail these two days |
Stack from ghstack (oldest at bottom):
Resolves most reported missing overloads from #865