Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlooked overload information on torchlib functions #919

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

BowenBao
Copy link
Contributor

@BowenBao BowenBao commented Jul 25, 2023

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #919 (1378db7) into main (241260f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #919   +/-   ##
=======================================
  Coverage   76.81%   76.81%           
=======================================
  Files         112      112           
  Lines       13547    13547           
  Branches     1377     1377           
=======================================
  Hits        10406    10406           
  Misses       2798     2798           
  Partials      343      343           
Files Changed Coverage Δ
onnxscript/function_libs/torch_lib/ops/core.py 77.44% <100.00%> (ø)

@BowenBao BowenBao marked this pull request as ready for review July 25, 2023 19:54
@BowenBao BowenBao added the topic: torch_lib Related to the torch/aten function lib in development label Jul 25, 2023
@titaiwangms
Copy link
Contributor

Are these all of them? I can start working on refactor get_aten_name in onnx dispatcher.

@titaiwangms titaiwangms requested review from justinchuby and titaiwangms and removed request for justinchuby July 25, 2023 20:56
@BowenBao
Copy link
Contributor Author

Are these all of them? I can start working on refactor get_aten_name in onnx dispatcher.

Updating with latest bench log.
There is aten::div.Tensor_Mode left, which should be unsupported, but somehow worked with fallback.

@justinchuby
Copy link
Collaborator

Maybe the rounding mode didn't affect things much?

@BowenBao
Copy link
Contributor Author

Maybe the rounding mode didn't affect things much?

Maybe. Maybe type promotion does the right thing for it. Maybe rounding_mode was not provided so the signature matched, and behavior also matched for default true_divide.

I think if rounding_mode is explicitly set, export will fail, as it should.

@BowenBao
Copy link
Contributor Author

@justinchuby do you know if CI / build_docs (windows-latest) (pull_request) failure is related?

@justinchuby
Copy link
Collaborator

No. It started to fail these two days

@BowenBao BowenBao changed the base branch from gh/BowenBao/6/base to main July 25, 2023 22:09
@BowenBao BowenBao merged commit f24797f into main Jul 25, 2023
28 of 29 checks passed
@BowenBao BowenBao deleted the gh/BowenBao/6/head branch July 25, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: torch_lib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants