Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move release pipeline to a separate file | chore(release) #619

Merged
merged 9 commits into from
Apr 11, 2023

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Apr 11, 2023

I moved the release pipeline out because the tests are sometimes flaky but we may not want them to block the scheduled release. I separated the dev and official releases to use different environments so the official releases can be manually reviewed before uploading to pypi.

Updated requirements-dev.txt

publish-dev:
needs: [release]
runs-on: ubuntu-latest
environment: PyPI Dev
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different environments are used here

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #619 (2019773) into main (5eafe2a) will not change coverage.
The diff coverage is n/a.

❗ Current head 2019773 differs from pull request most recent head 05c37b9. Consider uploading reports for the commit 05c37b9 to get more accurate results

@@           Coverage Diff           @@
##             main     #619   +/-   ##
=======================================
  Coverage   74.54%   74.54%           
=======================================
  Files         107      107           
  Lines       11302    11302           
  Branches     1177     1177           
=======================================
  Hits         8425     8425           
  Misses       2557     2557           
  Partials      320      320           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@justinchuby justinchuby added the run release CIs Release CI will run for PRs with this label label Apr 11, 2023
Copy link
Contributor

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we still add some tests after publishing wheels? Testing the built wheel can still be useful.

Just curious: which test is flaky? #567 this issue?

@justinchuby
Copy link
Collaborator Author

Shall we still add some tests after publishing wheels? Testing the built wheel can still be useful.

Sure

Just curious: which test is flaky? #567 this issue?

Yes. They are tracked in #539

@justinchuby justinchuby merged commit ba0ff2e into main Apr 11, 2023
@justinchuby justinchuby deleted the justinchu/release branch April 11, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run release CIs Release CI will run for PRs with this label topic: release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants