-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[torchlib] Fix aten::arange to support dynamic shapes #1913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, also interesting - does this mean we need to update https://github.com/pytorch/pytorch/blob/10f16cc7daf89a73c1177dfbd0bb0fbb0fc8683b/aten/src/ATen/native/native_functions.yaml#L780 ? Should we create an issue for propose a fix?
Should we also fix the rest of the arange overloads? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1913 +/- ##
=======================================
Coverage 75.45% 75.45%
=======================================
Files 252 252
Lines 27327 27335 +8
Branches 3172 3171 -1
=======================================
+ Hits 20619 20626 +7
Misses 5745 5745
- Partials 963 964 +1 ☔ View full report in Codecov by Sentry. |
Sure, I can update the whole family. And record the question that does Scalar cover sym_int and sym_float in Meta doc. |
Is it possible to add a unit test to make sure there is no regression about this? |
I will merge this first to unblock the model, and then come up with tests as follow-up. |
The old arange logic had issues with inconsistent types. Please make sure that's resolved. I am happy if you fix one and take time to ensure the rest of the variants are correct in a separate PR, if that allows faster progress |
Runinng SmolLM_1_7b with dynamic shapes discovered that arange.start was not dynamic anymore, since https://github.com/microsoft/onnxscript/pull/1781/files.