Inital StackCookie implementation for MSVC AARCH64 #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
os-d
approved these changes
Nov 13, 2024
| @@ -0,0 +1,80 @@ | |||
| ;------------------------------------------------------------------------------ | |||
| ; AARCH64/StackCheckFunctionsMsvc.nasm | |||
There was a problem hiding this comment.
Suggested change
| ; AARCH64/StackCheckFunctionsMsvc.nasm | |
| ; AARCH64/StackCheckFunctionsMsvc.asm | |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #1221 +/- ##
===========================================
Coverage 1.59% 1.59%
===========================================
Files 1449 1449
Lines 362730 362730
Branches 5632 5632
===========================================
Hits 5776 5776
Misses 356847 356847
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MSVC AARCH64 /GS support is untested. When it is enabled, the StackCheckLibNull does not satisfy the required externs required by the linker.
Adding support to StackCheckibNull for MSVC.
How This Was Tested
Compilation passes.
Integration Instructions
No changes required