Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UefiCpuPkg: Update ReadMe.txt to use Vtf0.inf #1173

Open
wants to merge 1 commit into
base: dev/202405
Choose a base branch
from

Conversation

VivianNK
Copy link
Contributor

@VivianNK VivianNK commented Oct 2, 2024

Description

ResetVector.inf does not exist. Update file path in ReadMe.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

N/A

Integration Instructions

N/A

@github-actions github-actions bot added impact:non-functional Does not have a functional impact type:documentation Improvements or additions to documentation labels Oct 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.59%. Comparing base (ebe0d3d) to head (1432959).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405    #1173   +/-   ##
===========================================
  Coverage        1.59%    1.59%           
===========================================
  Files            1448     1448           
  Lines          362501   362501           
  Branches         5632     5632           
===========================================
  Hits             5775     5775           
  Misses         356619   356619           
  Partials          107      107           
Flag Coverage Δ
UefiCpuPkg 4.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VivianNK VivianNK requested a review from apop5 October 18, 2024 23:10
ResetVector.inf does not exist. Update file path in ReadMe.

Signed-off-by: Vivian Nowka-Keane <[email protected]>
@VivianNK VivianNK force-pushed the personal/vnowkakeane/cpuPkgDocs branch from 0dca442 to 1432959 Compare October 21, 2024 19:40

Add this line to your FDF FV section:
INF RuleOverride=RESET_VECTOR UefiCpuPkg/ResetVector/Vtf0/ResetVector.inf
INF RuleOverride=RESET_VECTOR UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this go straight to edk2? Looks like the same issue exists there and should be non-controversial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants