Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from pkg/errors to Go 1.13+ error wrapping #2290

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Switch from pkg/errors to Go 1.13+ error wrapping #2290

wants to merge 2 commits into from

Commits on Oct 9, 2024

  1. cmd/containerd-shim-runhcs-v1/delete: stop using pkg/errors 

    There is no need to wrap errors from os package, as they already contain
extra information such as filename and which operation has failed.

Signed-off-by: Kir Kolyshkin <[email protected]>
    @kolyshkin
    kolyshkin committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3bd12f1 View commit details
    Browse the repository at this point in the history

  2. Switch from pkg/errors to Go 1.13+ error wrapping 

    The github.com/pkg/errors is mostly obsoleted since Go 1.13 introduced
%w-style error wrapping. It is also not maintained and is now archived
by the owner.

Some part of this change was done manually, and some changes were done
by using github.com/AkihiroSuda/go-wrap-to-percent-w tool.

In a few places this also:
 - changes '%s' or \"%s\" to %q;
 - removes extra context from the error message (such as, errors from os
   functions dealing with files do contain the file name already, and
   strconv.Atoi errors already contains the string which it failed to
   parse).

Note that there is a single place which uses StackTrace functionality of
pkg/errors, which is removed by this commit.

A few remaining users of pkg/errors vendored here (directly and
indirectly) are:
 - github.com/containerd/go-runc (needs to be bumped to v1.1.0);
 - github.com/microsoft/didx509go (needs microsoft/didx509go#19);
 - github.com/docker/cli (needs docker/cli#3618 fixed);
 - github.com/docker/docker (?)
 - github.com/linuxkit/virtsock (needs linuxkit/virtsock#69 merged);

Signed-off-by: Kir Kolyshkin <[email protected]>
    @kolyshkin
    kolyshkin committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1cabea0 View commit details
    Browse the repository at this point in the history