Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove graphrag.llm, replace with fnllm #1315

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

Conversation

darthtrevino
Copy link
Member

@darthtrevino darthtrevino commented Oct 23, 2024

Description

This PR replaces the graphrag.llm module with fnllm. This will be the first part of a migration incorporating fnllm. Some issues remain, including:

  • Extractors currently depend on an OpenAITextChatInstance instead of a more abstract interface. We will introduce a more abstract interface in fnllm.
  • fnllm creates its own limiters. We will introduce a mechanism for creating and using shared limiters.

Related Issues

[Reference any related issues or tasks that this pull request addresses.]

Proposed Changes

[List the specific changes made in this pull request.]

Checklist

  • I have tested these changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation (if necessary).
  • I have added appropriate unit tests (if applicable).

Additional Notes

[Add any additional notes or context that may be helpful for the reviewer(s).]

@darthtrevino darthtrevino marked this pull request as ready for review October 24, 2024 21:02
@darthtrevino darthtrevino requested review from a team as code owners October 24, 2024 21:02
natoverse
natoverse previously approved these changes Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants