-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add include options for script configuration #864
Conversation
} else { | ||
let tps = toolsPath | ||
if (!tps?.length) { | ||
tps = [GENAI_ANYJS_GLOB, ...arrayify(runtimeHost.config.include)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accessing 'runtimeHost.config.include' assumes that 'runtimeHost.config' is always defined. Ensure that 'runtimeHost.config' is initialized before accessing its properties to avoid potential runtime errors. 🔍
generated by pr-review-commit
runtimeHost_config_access
The changes in the pull request include:
The changes look well-structured and focused on improving adaptability and configurability of the tool execution process. LGTM 🚀
|
} else { | ||
let tps = arrayify(toolsPath) | ||
if (!tps?.length) { | ||
tps = [GENAI_ANYJS_GLOB, ...arrayify(runtimeHost.config.include)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of 'runtimeHost.config.include' assumes that 'runtimeHost.config' is always defined. Ensure that 'runtimeHost.config' is initialized before accessing its properties to avoid runtime errors.
generated by pr-review-commit
runtime_dependency
Introduce the
include
property to allow glob paths for including additional scripts, enhancing project configuration flexibility. Update related functions to support this new feature.