Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add read cache support #756

Merged
merged 10 commits into from
Nov 14, 2024
Merged

Add read cache support #756

merged 10 commits into from
Nov 14, 2024

Conversation

yrajas
Copy link
Contributor

@yrajas yrajas commented Oct 29, 2024 •
edited
Loading

  • Added config options to enable main store read cache, object store read cache and their corresponding memory settings
  • INFO command to report relevant read cache information
  • Heap size tracker to operate on read cache specific settings
  • Added tests and documentation.

@yrajas yrajas marked this pull request as ready for review October 31, 2024 04:38
TedHartMS
TedHartMS approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@TedHartMS TedHartMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with a couple tiny changes

libs/server/Metrics/Info/GarnetInfoMetrics.cs Show resolved Hide resolved
website/docs/getting-started/memory.md Show resolved Hide resolved
@yrajas yrajas merged commit f8578e1 into microsoft:main Nov 14, 2024
15 checks passed
@yrajas yrajas deleted the yrajas/readcache branch November 14, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TedHartMS TedHartMS TedHartMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yrajas @TedHartMS