Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compatibility] Added GETSET, SETNX, SUBSTR deprecated commands by mapping to existing commends #703

Merged
merged 12 commits into from
Oct 17, 2024
Merged

[Compatibility] Added GETSET, SETNX, SUBSTR deprecated commands by mapping to existing commends #703

merged 12 commits into from
Oct 17, 2024

Conversation

Vijay-Nirmal
Copy link
Contributor

@Vijay-Nirmal Vijay-Nirmal commented Oct 5, 2024 •
edited
Loading

  • Add GETSET, SETNX, SUBSTR option for HSCAN
  • Updated Test cases
  • Updated documentation for GETSET, SETNX, SUBSTR
  • Marked all deprecated comments in the doc

Part 1 of #684

vazois
vazois requested changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@vazois vazois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a slot verification test in ClusterSlotVeficationTests?

@Vijay-Nirmal
Copy link
Contributor Author

@vazois Added ClusterSlotVeficationTests

vazois
vazois requested changes Oct 14, 2024
View reviewed changes
libs/server/Resp/BasicCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/BasicCommands.cs Outdated Show resolved Hide resolved
@vazois
Copy link
Contributor

vazois commented Oct 17, 2024 •
edited
Loading

Thank you for your contributions!
Please resolve the conflicts.

@vazois vazois merged commit 6e76b25 into microsoft:main Oct 17, 2024
15 checks passed
@Vijay-Nirmal Vijay-Nirmal deleted the new/getset-setnx-substr-commands branch October 17, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vazois vazois vazois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vijay-Nirmal @vazois