-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster configuration merge protection #698
Open
vazois
wants to merge
16
commits into
microsoft:main
Choose a base branch
from
vazois:vazois/migrate-stress
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vazois
force-pushed
the
vazois/migrate-stress
branch
from
October 2, 2024 00:08
95c07e1
to
e287964
Compare
vazois
force-pushed
the
vazois/migrate-stress
branch
5 times, most recently
from
October 17, 2024 23:47
925ede8
to
b8fd6d2
Compare
vazois
force-pushed
the
vazois/migrate-stress
branch
11 times, most recently
from
October 28, 2024 17:20
a71ffad
to
f9a21c4
Compare
vazois
force-pushed
the
vazois/migrate-stress
branch
from
November 8, 2024 20:12
f9a21c4
to
f71b958
Compare
badrishc
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the merge config implementation to make it more robust in the presence of multiple back-to-back migration operations. It contains the following.
Description:
When a node receives a gossip message from a remote node it attempts to merge the incoming configuration to that of the local copy. This happens in two steps as follows:
The local node first updates the workers data structure (within the configuration object) which contains metadata for all known workers. This happens by either creating new worker information if that worker did not exist or updating the existing worker information if the configEpoch for that worker (from the perspective of the sender) is greater than the config epoch of the existing entry in its local copy.
The second step is to merge the slot-map information of the sender config. It does this by considering only those slots which according to the sender are in stable state, are claimed by the sender itself and for which the previous owner’s epoch (if there was a previous owner) is lesser than the sender’s (claimant’s) epoch.
The second step is very important because we don't want some node updating the slot map ownership for another node, especially during migration where slot exchange needs to be coordinated between the source and target nodes.