Invoke custom commands from custom proc/txn #597
+415
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrajas
force-pushed
the
yrajas/proctocmd
branch
2 times, most recently
from
c1391fc
to
f0450e4
Compare
yrajas
changed the title
yrajas
changed the title
yrajas
force-pushed
the
yrajas/proctocmd
branch
from
ba58f56
to
ce69dfe
Compare
badrishc
reviewed
Oct 28, 2024
Moved custom procs, txn to test project.
yrajas
force-pushed
the
yrajas/proctocmd
branch
from
5ed4735
to
3c6b5a9
Compare
badrishc
reviewed
Nov 8, 2024
badrishc
reviewed
Nov 8, 2024
TalZaccai
requested changes
Nov 14, 2024
| @@ -12,25 +12,40 @@ internal sealed class CustomCommandManagerSession | |||
| { | |||
| readonly CustomCommandManager customCommandManager; | |||
| public readonly (CustomTransactionProcedure, int)[] sessionTransactionProcMap; | |||
| public readonly CustomProcedure[] sessionCustomProcMap; | |||
There was a problem hiding this comment.
These 2 arrays can be made private, right? Also, might be good to add a comment that the arrays are indexed by the IDs.
|
|
||
| public CustomProcedure GetCustomProcedure(int id, RespServerSession respServerSession) | ||
| { | ||
| if (sessionCustomProcMap[id] == null) |
There was a problem hiding this comment.
Should we add a bounds check for the id? Also, are we sure we want to throw if the id is not found? Maybe just return null?
| var sbKey = key.SpanByte; | ||
|
|
||
| var inputArg = customCommand.expirationTicks > 0 ? DateTimeOffset.UtcNow.Ticks + customCommand.expirationTicks : customCommand.expirationTicks; | ||
| var sessionParseState = new SessionParseState(); |
There was a problem hiding this comment.
No need to instantiate a new parse state, you can use the session's parseState field.
|
|
||
| // Prepare input | ||
| var header = new RespInputHeader(customObjCommand.GetObjectType()) { SubId = customObjCommand.subid }; | ||
| var sessionParseState = new SessionParseState(); |
There was a problem hiding this comment.
Same here, no need to instantiate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to invoke custom raw string commands and object commands from within custom procedures and transactions.