feat: Hover Over Nav Item Behavior #33122
Draft
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Hej! Thanks Mason! Small bug I'm noticing but I'm getting a weird behavior on the pin button. After I click the pin, it toggles on to button fill--which is right, but it disappears completely after a couple seconds. I think it's still on because when I go to hover over that item, I can see that the pin is still on, but the pin should stay visible/filled even when the mouse leaves the area. Separately, this has more to do with the example: Can the text by the switch not change to something else as it gets switched on/off? Switch guidance says the text should always describe the positive state pf the setting, so I think the examples in the screenshot are good to use as the content. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared feature branch to implement the hover over behavior in Nav Items