Enable External Store use with Update Operation #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uired PartitionEntry
Co-authored-by: Will Sugarman <[email protected]>
wsugarman
reviewed
Aug 10, 2023
...icrosoft.Health.Dicom.Functions.UnitTests/Update/UpdateDurableFunctionTests.Orchestration.cs
Outdated
Show resolved
Hide resolved
...icrosoft.Health.Dicom.Functions.UnitTests/Update/UpdateDurableFunctionTests.Orchestration.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Functions/Update/Models/CompleteStudyArguments.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Functions/Update/Models/CompleteStudyArguments.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Functions/Update/UpdateDurableFunction.Activity.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Functions/Update/UpdateDurableFunction.Orchestration.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.SqlServer/Features/Schema/Migrations/44.diff.sql
Outdated
Show resolved
Hide resolved
wsugarman
reviewed
Aug 10, 2023
src/Microsoft.Health.Dicom.SqlServer/Features/Schema/Migrations/44.diff.sql
Show resolved
Hide resolved
esmadau
force-pushed
the
users/esmadau/idp-update
branch
from
348b541
to
35f3148
Compare
bcarthic
reviewed
Aug 10, 2023
| @@ -61,6 +62,7 @@ public static class ServiceCollectionExtensions | |||
| .AddFunctionsOptions<MigrationFilesOptions>(configuration, MigrationFilesOptions.SectionName) | |||
| .AddFunctionsOptions<QueryTagIndexingOptions>(configuration, QueryTagIndexingOptions.SectionName, bindNonPublicProperties: true) | |||
| .AddFunctionsOptions<PurgeHistoryOptions>(configuration, PurgeHistoryOptions.SectionName, isDicomFunction: false) | |||
| .AddFunctionsOptions<FeatureConfiguration>(configuration, "DicomServer:Features", isDicomFunction: false) | |||
There was a problem hiding this comment.
nit: Should this be a constant like others?
There was a problem hiding this comment.
will try to catch in next pr
bcarthic
reviewed
Aug 10, 2023
|
Dont' we need to update the new function name in appsettings? |
bcarthic
reviewed
Aug 10, 2023
src/Microsoft.Health.Dicom.SqlServer/Features/Schema/Sql/Sprocs/EndUpdateInstanceV44.sql
Show resolved
Hide resolved
…atermark as we use that to DELETE FROM dbo.FileProperty
… avoid confusion and fix index
esmadau
force-pushed
the
users/esmadau/idp-update
branch
from
ef1ba73
to
074716f
Compare
bcarthic
reviewed
Aug 11, 2023
src/Microsoft.Health.Dicom.SqlServer/Features/Schema/Sql/Sprocs/EndUpdateInstanceV44.sql
Show resolved
Hide resolved
wsugarman
previously approved these changes
Aug 11, 2023
wsugarman
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Update operation to work with external store.
Related issues
Addresses [AB#104373].
Testing
Updated existing tests and added new tests