Implement Torr Pressure-Converter Option #2121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tainability The code changes in this commit simplify the logic in the `OnAcceleratorKeyActivated` method of `KeyboardShortcutManager.cs`. - Replaced nested if-else statements with concise conditional expressions - Removed redundant checks for `altPressed` and `controlKeyPressed` - Consolidated return statements based on key combinations
…s.h. This commit adds the Pressure_Torr constant to the list of unit constants in the UnitConverterDataConstants.h file.
This commit adds the Torr unit to the list of pressure units in the UnitConverterDataLoader.cpp file. The Torr unit is assigned a value of 7 and its localized name and abbreviation are retrieved using GetLocalizedStringName(). Additionally, the conversion data for Torr is added to the GetConversionData() function.
The code changes include adding the unit abbreviation "Torr" for pressure measurement in the Resources.resw file. This change allows users to use "Torr" as an abbreviation when working with pressure calculations.
- Add new data entry for UnitName_Torr - Set value to "Torr" - Set comment to "A measurement unit for Pressure."
This commit adds a new conversion data entry for "Atmospheres-Torr" in the Test.resw file. The value of this conversion is 0.00131578947368.
The commit fixes a bug in the code where the pressure units were not being added correctly. The issue was resolved by moving the `emplace` statement after adding the `pressureUnits` vector.
|
@microsoft-github-policy-service agree |
|
@tian-lt - Apologies for the ping but would it be possible to merge this small MR? I'm not sure if there is someone else I should request reviews from. |
|
Thank you for proposing this PR, @JacobPoteet. Adding @hanzhang54 @guominrui here to see if they have time to help review. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2120.
Description of the changes:
How changes were validated: