Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push Notification Samples: Add section on differences between packaged and unpackaged Apps settings. #209

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

loneursid
Copy link
Contributor

@loneursid loneursid commented May 17, 2022

Description

  • Add section on differences between packaged and unpackaged apps settings for Push Notifications
  • Remove protocol section from appxmanifest since it isn't required for Push Notifications.

Target Release

WindowsAppSDK v1.1

Checklist

  • Samples build and run using the Visual Studio versions listed in the Windows development docs.
  • Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
  • Samples set the minimum supported OS version to Windows 10 version 1809.
  • Samples build clean with no warnings or errors.
  • [For new samples]: Samples have completed the sample guidelines checklist and follow standardization/naming guidelines.
  • If I am onboarding a new feature, then I must have correctly setup a new CI pipeline for my feature with the correct triggers and path filters laid out in the "Onboarding Samples CI Pipeline for new feature" section in samples-guidelines.md.
  • I have commented on my PR /azp run SamplesCI-<FeatureName> to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.

Samples/Notifications/Push/README.md Outdated Show resolved Hide resolved
Samples/Notifications/Push/README.md Outdated Show resolved Hide resolved
Samples/Notifications/Push/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants