Skip to content

Commit

Permalink
Merged PR 621256: [Scanner Admin APIs][Bug Fix] change expression to …
Browse files Browse the repository at this point in the history 
…string

change expression from ASMashupExpression to string to solve #210

Tests completed:
![image.png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/4f4b7330-5c73-4eb2-b9cb-d2f4c16debf7/pullRequests/621256/attachments/image.png)

Related work items: #1507497
  • Loading branch information
@msft-idoma
msft-idoma committed Sep 30, 2024
1 parent fddd78e commit 53a2427
Show file tree
Hide file tree
Showing 41 changed files with 382 additions and 595 deletions.
39 changes: 15 additions & 24 deletions sdk/PowerBI.Api/Source/Admin.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ public Admin(PowerBIClient client)
///
/// ## Permissions
///
/// The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator).
/// The user must be a Fabric administrator.
///
/// ## Required Scope
///
Expand Down Expand Up @@ -215,9 +214,8 @@ public Admin(PowerBIClient client)
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -363,8 +361,7 @@ public Admin(PowerBIClient client)
///
/// ## Permissions
///
/// The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator).
/// The user must be a Fabric administrator.
///
/// ## Required Scope
///
Expand Down Expand Up @@ -530,9 +527,8 @@ public Admin(PowerBIClient client)
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -692,8 +688,7 @@ public Admin(PowerBIClient client)
///
/// ## Permissions
///
/// The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator).
/// The user must be a Fabric administrator.
///
/// ## Required Scope
///
Expand Down Expand Up @@ -837,9 +832,8 @@ public Admin(PowerBIClient client)
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -1031,9 +1025,8 @@ public Admin(PowerBIClient client)
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -1230,9 +1223,8 @@ public Admin(PowerBIClient client)
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -1416,9 +1408,8 @@ public Admin(PowerBIClient client)
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down
78 changes: 30 additions & 48 deletions sdk/PowerBI.Api/Source/AdminExtensions.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ public static partial class AdminExtensions
///
/// ## Permissions
///
/// The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator).
/// The user must be a Fabric administrator.
///
/// ## Required Scope
///
Expand Down Expand Up @@ -52,8 +51,7 @@ public static TenantKey AddPowerBIEncryptionKey(this IAdmin operations, TenantKe
///
/// ## Permissions
///
/// The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator).
/// The user must be a Fabric administrator.
///
/// ## Required Scope
///
Expand Down Expand Up @@ -88,9 +86,8 @@ public static TenantKey AddPowerBIEncryptionKey(this IAdmin operations, TenantKe
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -121,9 +118,8 @@ public static TenantKeys GetPowerBIEncryptionKeys(this IAdmin operations)
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -160,8 +156,7 @@ public static TenantKeys GetPowerBIEncryptionKeys(this IAdmin operations)
///
/// ## Permissions
///
/// The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator).
/// The user must be a Fabric administrator.
///
/// ## Required Scope
///
Expand Down Expand Up @@ -193,8 +188,7 @@ public static TenantKey RotatePowerBIEncryptionKey(this IAdmin operations, Syste
///
/// ## Permissions
///
/// The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator).
/// The user must be a Fabric administrator.
///
/// ## Required Scope
///
Expand Down Expand Up @@ -232,9 +226,8 @@ public static TenantKey RotatePowerBIEncryptionKey(this IAdmin operations, Syste
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -268,9 +261,8 @@ public static TenantKey RotatePowerBIEncryptionKey(this IAdmin operations, Syste
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -311,8 +303,7 @@ public static TenantKey RotatePowerBIEncryptionKey(this IAdmin operations, Syste
///
/// ## Permissions
///
/// The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator).
/// The user must be a Fabric administrator.
///
/// ## Required Scope
///
Expand Down Expand Up @@ -341,8 +332,7 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
///
/// ## Permissions
///
/// The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator).
/// The user must be a Fabric administrator.
///
/// ## Required Scope
///
Expand Down Expand Up @@ -376,9 +366,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -428,9 +417,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -487,9 +475,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -543,9 +530,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -605,9 +591,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -652,9 +637,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -705,9 +689,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -762,9 +745,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down
10 changes: 4 additions & 6 deletions sdk/PowerBI.Api/Source/AppsOperations.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1216,9 +1216,8 @@ public AppsOperations(PowerBIClient client)
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -1394,9 +1393,8 @@ public AppsOperations(PowerBIClient client)
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down
20 changes: 8 additions & 12 deletions sdk/PowerBI.Api/Source/AppsOperationsExtensions.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -506,9 +506,8 @@ public static Tile GetTile(this IAppsOperations operations, System.Guid appId, S
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -551,9 +550,8 @@ public static Tile GetTile(this IAppsOperations operations, System.Guid appId, S
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -600,9 +598,8 @@ public static Tile GetTile(this IAppsOperations operations, System.Guid appId, S
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down Expand Up @@ -640,9 +637,8 @@ public static AppUsers GetAppUsersAsAdmin(this IAppsOperations operations, Syste
///
/// ## Permissions
///
/// - The user must have administrator rights (such as Office 365 Global
/// Administrator or Power BI Service Administrator) or authenticate using a
/// service principal.
/// - The user must be a Fabric administrator or authenticate using a service
/// principal.
/// - Delegated permissions are supported.
///
/// When running under service prinicipal authentication, an app **must not**
Expand Down
Loading

0 comments on commit 53a2427

Please sign in to comment.