Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] prevent categorical.model and model.txt files being left behind after testing #6590

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

neNasko1
Copy link
Contributor

@neNasko1 neNasko1 commented Aug 5, 2024

Contributes to #6361.

This PR prevents categorical.model and model.txt being left after executing pytest by using the tmp_path fixture, as suggested in the linked issue.

@neNasko1 neNasko1 changed the title [ci] prevent categorical.model and model.txt files being left behind after testing [ci] prevent categorical.model and model.txt files being left behind after testing Aug 5, 2024
@neNasko1
Copy link
Contributor Author

neNasko1 commented Aug 5, 2024

@jameslamb this a fix of the issue you linked as a good-first-issue in #6586

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great.

I've merged latest master into this, to be sure it's being tested against the latest code.

Looks like master on your fork (link) is about 2 weeks behind this repo:

Screenshot 2024-08-05 at 3 05 28 PM

In the future, please update master on your clone of the repo before cutting a new pull request branch.

@neNasko1
Copy link
Contributor Author

neNasko1 commented Aug 5, 2024

Thanks! This looks great.
I've merged latest master into this, to be sure it's being tested against the latest code.

Thanks for the time taken!

An R test is failing with a what seems to me connectivity error. Is that the case?:

Downloading https://github.com/microsoft/LightGBM/releases/download/v2.0.12/rtools43-5550-5548.exe
Invoke-WebRequest: D:\a\LightGBM\LightGBM\.ci\test-r-package-windows.ps1:12
Line |
  12 |      Invoke-WebRequest -Uri $url -OutFile $destfile
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | One or more errors occurred. (The response ended prematurely. (ResponseEnded))
Error: Process completed with exit code 1.

@jameslamb
Copy link
Collaborator

Yeah I think you're right that that's a temporary networking-related issue. I just manually re-triggered it.

@jameslamb jameslamb merged commit e31cf04 into microsoft:master Aug 6, 2024
45 checks passed
@jameslamb
Copy link
Collaborator

Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants