-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inference: remove unused _validate_args function #5505
Open
nelyahu
wants to merge
13
commits into
microsoft:master
Choose a base branch
from
nelyahu:remove_validate_args
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ed5786b
inference: remove unused _validate_args function
nelyahu f33f67b
Merge branch 'master' into remove_validate_args
tjruwase f14aad1
Merge branch 'master' into remove_validate_args
loadams 3aff4bc
Merge branch 'master' into remove_validate_args
loadams 1fa8f9e
Merge branch 'master' into remove_validate_args
loadams 75bef28
Merge branch 'master' into remove_validate_args
loadams 41d8978
Merge branch 'master' into remove_validate_args
loadams 7651593
Merge branch 'master' into remove_validate_args
loadams 8ac27e2
Merge branch 'master' into remove_validate_args
loadams f414cc0
Merge branch 'master' into remove_validate_args
loadams 61d47ef
Merge branch 'master' into remove_validate_args
loadams e2be709
Merge branch 'master' into remove_validate_args
loadams 36d69a7
Merge branch 'master' into remove_validate_args
loadams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nelyahu - we never added this functionality/checking to the pydantic config, let me take a stab at that before we merge this PR?