estimate_zero2_model_states_mem_needs: fixing memory estiamtion #5099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was considering 4 bytes per model param, and 4 bytes per gradient. fixed it to 2 bytes - under the assumption of FP16/BF16
tjruwase
reviewed
Feb 8, 2024
tjruwase
reviewed
Apr 13, 2024
tjruwase
reviewed
Apr 13, 2024
Applying code review suggestion to have more close estimation of memory consumption Co-authored-by: Olatunji Ruwase <[email protected]>
update comment Co-authored-by: Olatunji Ruwase <[email protected]>
tjruwase
approved these changes
May 13, 2024
|
@tjruwase can be merged? |
sfc-gh-reyazda
pushed a commit
to Snowflake-Labs/DeepSpeed
that referenced
this pull request
Jun 10, 2024
…osoft#5099) was considering 4 bytes per model param, and 4 bytes per gradient. fixed it to 2 bytes - under the assumption of FP16/BF16 --------- Co-authored-by: Olatunji Ruwase <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was considering 4 bytes per model param, and 4 bytes per gradient.
fixed it to 2 bytes - under the assumption of FP16/BF16