Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to pass --sdist <path-to-sdist> to avoid (re)building an sdist #165

Open
pradyunsg opened this issue Jun 28, 2023 · 1 comment

Comments

@pradyunsg
Copy link

This would be useful for development workflows where an sdist has been generated already -- instead of rebuilding the sdist in check-manifest again, it would make workflows quicker if it were possible to pass check-manifest an argument to use an already-created sdist.

@mgedmin
Copy link
Owner

mgedmin commented Jun 29, 2023

Thing is, check-manifest builds an sdist twice:

  • once directly in the source tree
  • once in a temporary directory with a clean copy of the source files

and then compares both to each other, and to the list of files in the VCS.

When the user provides an already-built sdist, should it be considered a direct one, or a clean one, or should there be two command line options?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants