Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.19.3] JEI menus use creative TooltipFlags instead of non-creative ones to match with the Creative Menu. #3111

Open
wants to merge 1 commit into
base: 1.19.3
Choose a base branch
from

Conversation

bconlon1
Copy link

@bconlon1 bconlon1 commented Jan 26, 2023

As of 1.19.3, a new type of TooltipFlag was added on to the pre-existing NORMAL and ADVANCED ones, gotten by using TooltipFlag.Default#asCreative() on either of these flags. This is used in the Creative menu as a way of having additional tooltip information for items displayed in tabs and not in the player's inventory.

This PR applies the change made to Creative menu tooltips to JEI's menus as well, due to the similar case of item display, which can be useful for mods that use this new way of determining what to display in a tooltip to have additional information tied to an item outside of the inventory.

2023-01-25_19 58 26
2023-01-25_19 58 37

… similar to the Creative Menu as of 1.19.3
@CLAassistant
Copy link

CLAassistant commented Jan 26, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


bconlon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants