Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not save token Id, if value is null #149

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

bratelefant
Copy link
Collaborator

Summary

Do not save token Id on logging in, if no value is provided

Linked issue(s)

#148

Involved parts of the project

User.js

Reproduction

cf. the PR; however, I could observe improved resuming of a suspended iOS app, successfully restoring the session user.

@bratelefant
Copy link
Collaborator Author

@jankapunkt Can you check why lint fails? Local npm run lint yields no errors, after I did a npm run lint:fix.

src/Tracker.js Outdated
? function () {
console.error.apply(console, arguments);
}
: function () {};
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the linter has some weird understanding of indentation on nested ternary operators. Maybe this one might work:

if (typeof Meteor !== 'undefined') {
  return Meteor._debug;
}

return typeof console !== 'undefined' && console.error
  ? function () { console.error.apply(console, arguments); }
  : function () {};

src/user/User.js Outdated Show resolved Hide resolved
@bratelefant
Copy link
Collaborator Author

Ok looks like lint is working now. Could figure out why it did not throw any errors on my box though...

@jankapunkt jankapunkt merged commit 8c26120 into fix/connection-events Feb 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meteor.user() is sometimes undefined on resuming the app from background
2 participants