Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Navigation between protected and unprotected routes #3034

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve Navigation between protected and unprotected routes #3034

wants to merge 2 commits into from

Conversation

anshg1214
Copy link
Member

@anshg1214 anshg1214 commented Nov 14, 2024 •
edited
Loading

This PR solves two problems:

  1. The navigation history breaks when you try to access a protected route while you're logged out.
  2. During this navigation, the protected route is rendered once before going to the login page.

@anshg1214 anshg1214 marked this pull request as ready for review November 15, 2024 13:51
MonkeyDo
MonkeyDo approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't figure out how to test this or how to reproduce the issue described in the description, but the code looks fine and after deploying to test.LB for testing everything is workign fine, so 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshg1214 @MonkeyDo