LB-1419: Fix broken partial dates #3029
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mayhem! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
This PR is also temporarily deployed, anticipating the monthly rebuild of all of the data. |
amCap1712
reviewed
Nov 14, 2024
| @@ -133,9 +133,16 @@ def create_json_data(self, row): | |||
| tag["genre_mbid"] = genre_mbid | |||
| release_group_tags.append(tag) | |||
|
|
|||
|
|
|||
| date = str(row["year"] or '') | |||
| if row["month"] is not None: | |||
There was a problem hiding this comment.
Is this the same format that MB follows for partial dates because consider a date where the month is unknown but the year and day are, it could be formatted as 2024-01 which is easily misunderstood.
There was a problem hiding this comment.
MB dates are not allowed to have a day without a month. YYYY, YYYY-MM, YYYY-MM-DD are the only valid forms.
amCap1712
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MB data cashes have invalid partial dates for release_group data. The problem is that when any part of a || concat expression in PG is NULL, the entire result is NULL. The solution is to move the partial data logic into python code.