feat: improve apple music fuzzy matching #3011
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonkeyDo
reviewed
Nov 6, 2024
| if (fruzzyMatches[0]) { | ||
| await this.playAppleMusicId(fruzzyMatches[0].obj.id); | ||
|
|
||
| const matchWithAlbum = fuzzyMatches.find((match) => { |
There was a problem hiding this comment.
This should probably only be run if releaseName is truthy (I believe it is optional in the listen metadata so could potentially be undefined/null).
I'm also reading the documentation for fuzzysort, and I wonder if instead of a secondary pass, this couldn't all be achieved in a single pass (when calling fuzzysort.go above )by:
- using both keys
attributes.nameandattribute.albumName - passing a custom
scoreFnthat boosts results that match the albumName
(See 'advanced usage' section https://github.com/farzher/fuzzysort?tab=readme-ov-file#advanced-usage )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.