fix: Release Group Artist Credits are duplicated #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @anshg1214! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
mayhem
reviewed
Nov 11, 2024
| @@ -85,7 +85,7 @@ def create_json_data(self, row): | |||
| "name": release_group_name, | |||
| "mbid": release_group_mbid, | |||
| "artist_credit_name": artist_credit_name, | |||
| "artists": release_group_artists | |||
| "artists": sorted(release_group_artists, key=lambda x: x.pop("position", float('inf'))) | |||
There was a problem hiding this comment.
Why are you using pop() here? Did you want to modify the list or simply dereference it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Release Group Artist Credits which are duplicated due to the second join to the artist_credit_name.