Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue5194 external notification module refactor #5384

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Issue5194 external notification module refactor #5384

wants to merge 5 commits into from
+119 −122

Commits on Nov 17, 2024

  1. Remove unnecessary nesting

    @Blake-Latchford
    Blake-Latchford committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    975d443 View commit details
    Browse the repository at this point in the history

  2. Centralize ExternalNotificationModule LED handling 

    This PR attemtps to take a small step towards addressing issue 5194
by de-duplicating LED handling code within ExternalNotificationModule.
I also refactored the color state code around an alpha channel approach.
    @Blake-Latchford
    Blake-Latchford committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    426e804 View commit details
    Browse the repository at this point in the history

  3. Centralize ExternalNotificationModule LED handling 

    This PR attemtps to take a small step towards addressing issue 5194
by de-duplicating LED handling code within ExternalNotificationModule.
I also refactored the color state code around an alpha channel approach.
    @Blake-Latchford
    Blake-Latchford committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    c566a9f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into issue5194-external-notification-module-ref… 

    …actor
    @thebentern
    thebentern authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    2f582ee View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Merge branch 'master' into issue5194-external-notification-module-ref… 

    …actor
    @thebentern
    thebentern authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    9bea005 View commit details
    Browse the repository at this point in the history