Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor unstructured mesh generation #40

Merged
merged 31 commits into from
Nov 14, 2024
Merged

Refactor unstructured mesh generation #40

merged 31 commits into from
Nov 14, 2024

Conversation

jwallwork23
Copy link
Member

@jwallwork23 jwallwork23 commented Nov 2, 2024 •
edited
Loading

Partially addresses #17.
Partially addresses #7.

This PR refactors the square and random polygonal mesh generators and adds docstrings and unit tests. It also deletes a .msh file that probably wasn't meant to be added to the repo.

@jwallwork23 jwallwork23 added documentation Improvements or additions to documentation refactor A suggested reworking of the code testing Extensions and improvements to the testing infrastructure labels Nov 2, 2024
@jwallwork23 jwallwork23 self-assigned this Nov 2, 2024
@jwallwork23 jwallwork23 mentioned this pull request Nov 2, 2024
Open
@jwallwork23 jwallwork23 marked this pull request as ready for review November 2, 2024 16:59
ddundo
ddundo approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@ddundo ddundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm not too familiar with UM2N. But approving this if that's all you wanted from me :)

@jwallwork23
Copy link
Member Author

Sorry, I'm not too familiar with UM2N. But approving this if that's all you wanted from me :)

Me neither... Did you review it or just click approve? Could do with checking that what I came up with is sensible. There's no ML in there, just mesh generation code, so shouldn't require familiarity with UM2N.

ddundo
ddundo approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@ddundo ddundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed now :) Just minor comments and suggestions (feel free to ignore if you disagree of course)

UM2N/generator/unstructured_mesh.py Outdated Show resolved Hide resolved
UM2N/generator/unstructured_mesh.py Outdated Show resolved Hide resolved
UM2N/generator/unstructured_mesh.py Outdated Show resolved Hide resolved
UM2N/generator/unstructured_mesh.py Outdated Show resolved Hide resolved
UM2N/generator/unstructured_mesh.py Outdated Show resolved Hide resolved
UM2N/generator/unstructured_mesh.py Show resolved Hide resolved
UM2N/generator/unstructured_mesh.py Outdated Show resolved Hide resolved
UM2N/model/train_util.py Outdated Show resolved Hide resolved
script/build_helmholtz_square.py Outdated Show resolved Hide resolved
tests/test_unstructured_mesh.py Outdated Show resolved Hide resolved
This was referenced Nov 14, 2024
Open
Open
@jwallwork23 jwallwork23 merged commit 567bee3 into main Nov 14, 2024
1 check passed
@jwallwork23 jwallwork23 deleted the 17_refactor_meshgen branch November 14, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddundo ddundo ddundo approved these changes

Assignees

@jwallwork23 jwallwork23

Labels
documentation Improvements or additions to documentation refactor A suggested reworking of the code testing Extensions and improvements to the testing infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwallwork23 @ddundo