Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to RxJava3 #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

KeithYokoma
Copy link
Contributor

@KeithYokoma KeithYokoma commented Feb 18, 2020

@KeithYokoma KeithYokoma self-assigned this Feb 18, 2020
@KeithYokoma KeithYokoma added the enhancement New feature or request label Feb 18, 2020
@hirak
Copy link

hirak commented Feb 18, 2020

Codecov Report

Merging #29 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage     98.18%   98.18%           
  Complexity        8        8           
=========================================
  Files             7        7           
  Lines           330      330           
  Branches         14       14           
=========================================
  Hits            324      324           
  Misses            1        1           
  Partials          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cbd11b...887f8e6. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage     98.18%   98.18%           
  Complexity        8        8           
=========================================
  Files             7        7           
  Lines           330      330           
  Branches         14       14           
=========================================
  Hits            324      324           
  Misses            1        1           
  Partials          5        5
Impacted Files Coverage Δ Complexity Δ
...c/test/java/com/mercari/rxredux/MultiThreadTest.kt 94.87% <ø> (ø) 2 <0> (ø) ⬇️
...redux/src/main/java/com/mercari/rxredux/RxRedux.kt 96.55% <ø> (ø) 0 <0> (ø) ⬇️
...x/src/test/java/com/mercari/rxredux/RxReduxTest.kt 99.44% <100%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cbd11b...887f8e6. Read the comment docs.

@kittinunf
Copy link
Contributor

kittinunf commented Feb 19, 2020

Looks golden to me!

Btw, on the side note since the introduction of DisposableContainer or CompositeDisposable, I think we should improve this API surface

override fun dispatch(vararg actions: Observable<out A>): List<Disposable>

to

override fun dispatch(vararg actions: Observable<out A>): [DisposableContainer | CompositeDisposable]

Since we are about to update this into the new version (I think it has been battle-tested in Merpay long enough to promote RxRedux to version 1.0.0), I might be a good time to rethink the API surface a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants