-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to RxJava3 #29
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=========================================
Coverage 98.18% 98.18%
Complexity 8 8
=========================================
Files 7 7
Lines 330 330
Branches 14 14
=========================================
Hits 324 324
Misses 1 1
Partials 5 5 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=========================================
Coverage 98.18% 98.18%
Complexity 8 8
=========================================
Files 7 7
Lines 330 330
Branches 14 14
=========================================
Hits 324 324
Misses 1 1
Partials 5 5
Continue to review full report at Codecov.
|
Looks golden to me! Btw, on the side note since the introduction of override fun dispatch(vararg actions: Observable<out A>): List<Disposable> to override fun dispatch(vararg actions: Observable<out A>): [DisposableContainer | CompositeDisposable] Since we are about to update this into the new version (I think it has been battle-tested in Merpay long enough to promote RxRedux to version 1.0.0), I might be a good time to rethink the API surface a bit. |
Migration Note: https://github.com/ReactiveX/RxJava/wiki/What's-different-in-3.0