Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/agnosis pull request #840

Open
wants to merge 77 commits into
base: develop
Choose a base branch
from
Open

Conversation

matthew-a-feraru
Copy link

Changes

Base implementation of debugger for Silver

Documentation

  • Undergrad AGnosis team: first version of Attribute Grammars debugger for Silver.
  • Docs on MELT website already or in progress.

Testing

  • Tested with command-line debugger interface and some with new VS code extension in progress.

krame505 and others added 30 commits November 9, 2023 19:30
… into, and created a generic intInput function
Cauth006 and others added 27 commits April 11, 2024 15:15
…ll backwards now (backtrack still exist for the easter egg)
… and some comments have been added to each
@@ -0,0 +1,27 @@
package common;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugger-specific files should be moved to runtime/java/src/common/agnosis/


//More detailed information about specific calls
else if(userInputList.length == 2){
if(userInputList[1].equals("up")){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be cleaner as a switch statement.

private String[] toggleChoices;

private boolean isRoot(DecoratedNode dn) {
return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confusing indentation

}

//Replaces currentNode with its parent
public Integer up()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason these functions return Integer instead of int?

String[] attributeArrayView = attributeListView.toArray(new String[attributeListView.size()]);
System.out.println("Which attribute?");
displayArray(attributeArrayView);
System.out.print(">DEBUGGER-PROMPT$");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit confusing that the prompt is the same for choosing the attribute. Could just have "Which attribute? " as the prompt.

@@ -0,0 +1,71 @@
# agnosis README
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove or update this template README file?

@@ -0,0 +1,43 @@
# Welcome to your VS Code Extension
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove or update this template file?

"request": "launch",
"args": [
"--extensionDevelopmentPath=${workspaceFolder}",
"--folder-uri=file:///home/tardis/Documents/example_expr_translator-main/translator"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded local path?

@@ -0,0 +1,87 @@
//package agnosis-context.libs.visualization;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class doesn't seem to be used anywhere - remove? Seems redundant with Location anyway.

}

}
//TODO: Add way to access children names
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is resolved now, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants