-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/agnosis pull request #840
base: develop
Are you sure you want to change the base?
Conversation
…object map is its own function
…into feature/agnosis
…into feature/agnosis
…for is-new label only
…ks on everything in translator grammar
… into, and created a generic intInput function
…into feature/agnosis
…ll backwards now (backtrack still exist for the easter egg)
…-umn/silver into feature/agnosis
…ll matthews changes
…into feature/agnosis
…into feature/agnosis
… and some comments have been added to each
…LHS data, old functions removed
…into feature/agnosis
@@ -0,0 +1,27 @@ | |||
package common; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debugger-specific files should be moved to runtime/java/src/common/agnosis/
|
||
//More detailed information about specific calls | ||
else if(userInputList.length == 2){ | ||
if(userInputList[1].equals("up")){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be cleaner as a switch statement.
private String[] toggleChoices; | ||
|
||
private boolean isRoot(DecoratedNode dn) { | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confusing indentation
} | ||
|
||
//Replaces currentNode with its parent | ||
public Integer up() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason these functions return Integer
instead of int
?
String[] attributeArrayView = attributeListView.toArray(new String[attributeListView.size()]); | ||
System.out.println("Which attribute?"); | ||
displayArray(attributeArrayView); | ||
System.out.print(">DEBUGGER-PROMPT$"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit confusing that the prompt is the same for choosing the attribute. Could just have "Which attribute? "
as the prompt.
@@ -0,0 +1,71 @@ | |||
# agnosis README |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove or update this template README file?
@@ -0,0 +1,43 @@ | |||
# Welcome to your VS Code Extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove or update this template file?
"request": "launch", | ||
"args": [ | ||
"--extensionDevelopmentPath=${workspaceFolder}", | ||
"--folder-uri=file:///home/tardis/Documents/example_expr_translator-main/translator" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded local path?
@@ -0,0 +1,87 @@ | |||
//package agnosis-context.libs.visualization; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class doesn't seem to be used anywhere - remove? Seems redundant with Location
anyway.
} | ||
|
||
} | ||
//TODO: Add way to access children names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is resolved now, correct?
Changes
Base implementation of debugger for Silver
Documentation
Testing