Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate matrix with item-piechart directive #371

Merged
merged 30 commits into from
Apr 16, 2024
Merged

Generate matrix with item-piechart directive #371

merged 30 commits into from
Apr 16, 2024

Conversation

JasperCraeghs
Copy link
Member

@JasperCraeghs JasperCraeghs commented Mar 13, 2024 •
edited
Loading

  • rough implementation
  • tweak table layout: group by result with result in rowspan/subheader
  • clean up code
  • testing
  • documentation

Closes #368

FYI @gcrabbe

@JasperCraeghs JasperCraeghs changed the title Draft: Generate matrix with item-piechart directive Generate matrix with item-piechart directive Mar 19, 2024
@JasperCraeghs JasperCraeghs changed the title Generate matrix with item-piechart directive Draft: Generate matrix with item-piechart directive Mar 26, 2024
@JasperCraeghs
Copy link
Member Author

JasperCraeghs commented Mar 26, 2024 •
edited
Loading

The case-insentivity of the labels must be taken into account. The following configuration doesn't produce any items/rows in the matrix under the subheader ERROR because it's not all lowercase:

    :result: ERROR, fail, pass
    :matrix:

This was a bug. Resolved by 23c502b

@JasperCraeghs JasperCraeghs mentioned this pull request Mar 26, 2024
Merged
@JasperCraeghs JasperCraeghs changed the title Draft: Generate matrix with item-piechart directive Generate matrix with item-piechart directive Mar 26, 2024
Letme
Letme requested changes Apr 15, 2024
View reviewed changes
doc/requirements.rst Show resolved Hide resolved
doc/requirements.rst Outdated Show resolved Hide resolved
mlx/traceability/directives/item_pie_chart_directive.py Show resolved Hide resolved
mlx/traceability/directives/item_pie_chart_directive.py Show resolved Hide resolved
@Letme Letme merged commit 3bc1c3d into master Apr 16, 2024
7 checks passed
@Letme Letme deleted the pie-chart-to-matrices branch April 16, 2024 15:04
@JasperCraeghs JasperCraeghs mentioned this pull request Apr 16, 2024
Merged
@gcrabbe gcrabbe mentioned this pull request Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Letme Letme Letme approved these changes

Assignees

@Letme Letme

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

item-matrix should support the same categories as item-piechart
2 participants
@JasperCraeghs @Letme