Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-browser event path #678

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Cross-browser event path #678

wants to merge 2 commits into from

Conversation

Micrufun
Copy link
Contributor

Fix errors on web browsers due to usage of the non-standard path property of event objects:

Firefox:

Screenshot_20221218_181237--crop

Chromium:

Screenshot_20221218_181541--crop

Test

Tests indicate that the errors are resolved.

@Micrufun
Copy link
Contributor Author

Reference

Please refer to: https://stackoverflow.com/a/39245638/3405291

hide();
}
} else {
Console.log("This browser doesn't supply event path information")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a typo here (Console)

Copy link
Contributor

@Megidd Megidd Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgogoulos Typo is fixed ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants