Allow DIFAT chains to end with FREESECT #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specification says that the final DIFAT page, which has no successor, must terminate with ENDOFCHAIN (0xFFFFFFFE). In practice, I have found Excel xls files, which are CFB files, that just use FREESECT (0xFFFFFFFF). Since Excel will open these non-standard files without complaint, this must be a tolerated divergence from the rules in the wild.
jmacadie
commented
Feb 12, 2024
data/bad.xls
Outdated
There was a problem hiding this comment.
I shouldn't have included this. Will remove
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification says that the final DIFAT page, which has no successor, must terminate with ENDOFCHAIN (0xFFFFFFFE). In practice, I have found Excel xls files, which are CFB files, that just use FREESECT (0xFFFFFFFF).
Since Excel will open these non-standard files without complaint, this must be a tolerated divergence from the rules in the wild.
Resolves #49