-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maplike and Setlike objects in Map and Set #27160
Conversation
Preview URLs (14 pages)
Flaws (16)Note! 9 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
(comment last updated: 2023-06-16 15:08:29) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Casual reviews
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These "definitions" are IDL definitions, not glossary terms. Glossary entries define terms. This content is better suited for /en-US/docs/Web/API/ or Web/JavaScript/Reference under the official name of the IDL/spec, with a summary in the glossary pointing to that documentation and example implementations within MDN and in the wild.
I am open to adding them as a subsection under the |
Thanks. I don't disagree. Though note, this is the same approach as transferrable objects and serializable objects in the glossary. I quite like the idea of having these as sections in Map and Set. @wbamberg any comments? |
https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Transferable_objects is now a Web API page as well. |
There are a few glossary items, including these, that need to be revisited and de-glossary-ified (Base 64 is another one). Now that transferable objects has an API page, it will be easier to do. Let's not add to that. I also quite like the idea of having these as sections in Map and Set as @Josh-Cena suggested |
I do too. I'll looking to moving this stuff either Friday or next week, firefox-project work permitting. |
We talked about this in the SC meeting on Wednesday. I had forgotten about transferable and serializable, and agree that they're the same kind of thing. I agree that glossary is not a great place to put pages like this, and am happy FWIW for them to go in the JS docs, for now. But I think we need a proper home for pages like this, that cover general categories in Web/API. In the SC meeting we talked about having a project in H2 to figure out a proper home for them. |
390bf96
to
f35c9a4
Compare
@wbamberg Thanks for the information. That all makes sense to me, though for this particular case adding this to Map/Set feels like a good fit. The only problem is that it is cleaner not to mix JavaScript and WebAPI. @Josh-Cena I have moved this to the Map and Set topics so good time for a new review. |
files/en-us/web/javascript/reference/global_objects/set/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/set/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/map/index.md
Outdated
Show resolved
Hide resolved
@Josh-Cena @wbamberg Would appreciate a review on this when you have time. I have updated the titles to "X-like browser APIs" in the respective docs to reflect upcoming JavaScript Set-like objects. |
files/en-us/web/javascript/reference/global_objects/set/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/set/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/map/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/set/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/set/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Joshua Chen <[email protected]>
Co-authored-by: Joshua Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little nits. @wbamberg said about making a dedicated page for web IDL entities (IIUC); I don't have strong opinions but that does sound more scalable.
files/en-us/web/javascript/reference/global_objects/map/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/set/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/set/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Joshua Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's pick one. I don't have preferences
files/en-us/web/javascript/reference/global_objects/set/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Joshua Chen <[email protected]>
Thanks. Works for me. |
Can we merge this? |
Oops, @hamishwillee—you were supposed to pick one suggestion (indent by 2 or 4)... |
files/en-us/web/javascript/reference/global_objects/map/index.md
Outdated
Show resolved
Hide resolved
@Josh-Cena I guess I should learn to read - saw that as fixes to two cases. I have decided on "2 spaces". Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving and will merge in the next few days unless @wbamberg gives a -1 on the current approach.
files/en-us/web/javascript/reference/global_objects/map/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Elchi3 filed openwebdocs/project#159 which might revisit things, but this is fine. Thank you @hamishwillee !
These glossary entries are designed to make it easier to talk about setlike and maplike objects, and what APIs might be present in both readonly and read/write versions.
I've listed the items I could find in both types in the appropriate entries.
I also added a comment about the IDL.
Follows on from comment in #27028 (comment)
FYI @wbamberg