-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use same set of headers in default mode and mutant-tracking mode #343
Conversation
@afd seems like the window build failed because The workaround is adding Could you let me know where to modify the workflow script to add MSVC compiler flag? Is it this line here? |
From the CI logs I see: cl.exe '/std:c17 /experimental:c11atomics' -c add.c It looks like the two flags are being passed as if they were a single flag, due to the use of quotes. Hopefully if the quotes are eliminated this will work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but some changes suggested.
b6cd9e1
to
d089efb
Compare
d089efb
to
d3e5201
Compare
Previously, dredd included different sets of headers for default mode
and mutant-tracking mode. This could alter macro definitions and lead to
the manual insertion of
void __dredd_prelude_start();
in one mode butnot the other. To ensure consistency across both modes, Dredd now emits
the union of headers from both modes.
Fixes #342 .