More Flexible subtype resolver #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olving sub types. Fixes: mbknor#137 Rather than providing a callback, just move the actual code for resolving subtypes into the resolver itself. Then users are free to implement what they like here. Obviously, it's their responsibility that this aligns with what ever weird and wonderful serialization logic they have.
|
Thanks. This looks interesting. I'm looking into it.. |
|
I think it should be, but haven't tried it. Definitely worth testing! |
|
Updated dependencies would also help me, if you're able #136 |
|
Thoughts on this change @mbknor. Feel free to close the PR is you're not going to merge / adopt... |
1 similar comment
|
Thoughts on this change @mbknor. Feel free to close the PR is you're not going to merge / adopt... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #137
Alternative to: #138
Note: built on top of #138 - sorry, being a bit lazy.
Rather than providing a callback, just move the actual code for resolving subtypes into the resolver itself. Then users are free to implement what they like here.
Obviously, it's their responsibility that this aligns with what ever weird and wonderful serialisation logic they have.
I've tried to make the change backwards compatible. Though I'm no Scala expert.
I think the introduction of the
SubTypeResolvertrait matches up well with the fix in #135, i.e. its no longer classes, but types, that are being resolved.Personally, I prefer this pattern to #138.