-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) set memory baseline on MemoryCollector #559
Conversation
In the case of Laravel, wouldn't this discard the memory usage from the process up to the constructor of this class? |
Yes, before the service provider. |
For the Octane problem, it would be enough to provide a method to reset for subsequent executions, but calling the memory_reset_peak_usage function might have unexpected results for other tools. |
Yes but the actual process is using the highest variant, right? |
I removed it from the constructor (for now). We can add it to the laravel-debugbar if Octane is running for example. |
Without |
Fixes barryvdh/laravel-debugbar#1324
Fixes barryvdh/laravel-debugbar#1434
This pr allows only the memory peak to be shown with a baseline, this would normalize the differences in the presentation, currently the maximum peak of the process is shown, but only the memory used by the application should be shown
For example, in Windows a fresh app shows 20MB, while the same app in Linux only shows 3MB.
Added
memory_reset_peak_usage
for only check execution peaks