Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rc_type_crsf #2162

Merged
merged 5 commits into from
Nov 6, 2024
Merged

add rc_type_crsf #2162

merged 5 commits into from
Nov 6, 2024

Conversation

benjinne
Copy link
Contributor

@benjinne benjinne commented Nov 4, 2024

Based on recommendation to add for CRSF binding
PX4/PX4-Autopilot#23294 (comment)

@hamishwillee
Copy link
Collaborator

hamishwillee commented Nov 5, 2024

Thanks @benjinne .

I created a simpler version in #2163 before I saw this.

I think your version here might be better. Will discuss in mav call.

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benjinne As per #2163 (comment) I think this is a good change in that it reflects the way that flight stacks are using the message currently - we can't break that.

@julianoes FYI, I'm going to merge. For all the same radio types as previously the same command params would be set for the same radio. @benjinne Also has a QGC implementation, so if there are issues, that will catch them.

@hamishwillee hamishwillee merged commit e221d46 into mavlink:master Nov 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants