Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Node requirement from 18 to 20 (current LTS) #80

Merged
merged 7 commits into from
Oct 27, 2024
Merged

Increase Node requirement from 18 to 20 (current LTS) #80

merged 7 commits into from
Oct 27, 2024

Conversation

mattbrictson
Copy link
Owner

No description provided.

@mattbrictson mattbrictson added the ✨ Feature Adds a new feature label Aug 7, 2024
@mattbrictson
Copy link
Owner Author

mattbrictson commented Aug 7, 2024 •
edited
Loading

Looks like the default GitHub Actions runner still uses Node 18, so it is probably too soon to upgrade.

Once GitHub adopts ubuntu-24.04 as ubuntu-latest, we should be good to go.

https://github.com/actions/runner-images

@mattbrictson mattbrictson marked this pull request as draft August 7, 2024 18:06
@park-jemin
Copy link

Bumping this - GitHub has ubuntu-24.04 as the latest :)

@mattbrictson
Copy link
Owner Author

This announcement says regarding the change to ubuntu-24.04

This change will be rolled out over a period of several weeks beginning in September 25th, 2024. We plan to complete the migration by October 30th , 2024.

actions/runner-images#10636

Just to be safe, I think I will wait until the October 30th date.

@mattbrictson
Copy link
Owner Author

The aforementioned actions/runner-images#10636 has been updated with this note:

NOTICE: THIS ROLLOUT HAS BEEN PUT ON HOLD

No explanation was given.

So I guess we will need to continue waiting on merging this PR.

@mattbrictson mattbrictson marked this pull request as ready for review October 27, 2024 04:00
@mattbrictson
Copy link
Owner Author

mattbrictson commented Oct 27, 2024 •
edited
Loading

Instead of waiting for ubuntu-latest to be updated, I instead opted into ubuntu-24.04 explicitly (see #129). This gives us the more recent version of Node. We're no longer blocked by the ubuntu-latest rollout.

@mattbrictson mattbrictson added the automerge Automatically merge PR once all required checks pass label Oct 27, 2024
@mattbrictson mattbrictson changed the title Increase Node requirement from 18 (EOL) to 20 (current LTS) Increase Node requirement from 18 to 20 (current LTS) Oct 27, 2024
@kodiakhq kodiakhq bot merged commit 718fe86 into main Oct 27, 2024
16 checks passed
@kodiakhq kodiakhq bot deleted the node-20 branch October 27, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge Automatically merge PR once all required checks pass ✨ Feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattbrictson @park-jemin