Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make chargers attributable #3565

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

sebhoerl
Copy link
Contributor

@sebhoerl sebhoerl commented Nov 14, 2024

This PR makes ChargerSpecification and indirectly Charger attributable. The functionality is provided to read and write chargers with attributes just like it works for persons, facilities, etc.

While doing this, the PR also adds a general unit test for reading/writing chargers, plus another one where attributes are used.

The DTD for the chargers is changed in this PR. I don't think we need to introduce a v2, because the basic structure is not changed, only the attributes are added as an optional feature. But may somebody who is more familiar with how DTDs are handled can comment on this?

@kt86
Copy link
Contributor

kt86 commented Nov 15, 2024

Only my opinion re DTD:
Additional attributes in the DTD does not require a version change. Because it is not breaking anything. Thus, we do not need it, and it makes effort without gaining anything.
I only do all the work with a new version, if I change/remove existing stuff, that will break anything.
-> Please go ahead

Thanks for adding tests!

@sebhoerl sebhoerl merged commit 8969b53 into master Nov 15, 2024
49 checks passed
@sebhoerl sebhoerl deleted the feat/attributable-chargers branch November 15, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants