Don't require commands be uppercase when using !cmd
#1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using `!cmd` IRC commands can be lowercase. Signed-off-by: Ferass El Hafidi <[email protected]>
Signed-off-by: Ferass El Hafidi <[email protected]>
Signed-off-by: Ferass El Hafidi <[email protected]>
Half-Shot
approved these changes
Sep 18, 2024
| const commands = [ | ||
| `!cmd ${roomMapping.server} JOIN ${newChannel}`, | ||
| `!cmd ${roomMapping.server} TOPIC ${newChannel} :some new fancy topic`, | ||
| `!cmd ${roomMapping.server} PART ${newChannel}`, | ||
| `!cmd ${roomMapping.server} STUPID COMMANDS`, | ||
| `!cmd rubbishserver SOME COMMAND`]; |
There was a problem hiding this comment.
we've lost the test for an invalid server here?
There was a problem hiding this comment.
With this change "rubbishserver" is now interpreted as a command rather than as a server.
There was a problem hiding this comment.
right...we still need to interpret servers here.
There was a problem hiding this comment.
They are interpreted correctly when valid, but rubbishserver matches the new regex.
Perhaps that could be replaced by rubbish^server! or something?
Half-Shot
reviewed
Sep 18, 2024
| @@ -885,14 +885,12 @@ describe("Admin rooms", function() { | |||
| cmdIx++; | |||
| }); | |||
|
|
|||
| // 5 commands should be executed | |||
| // rubbishserver should not be accepted | |||
| // 4 commands should be executed | |||
| const commands = [ | |||
| `!cmd ${roomMapping.server} JOIN ${newChannel}`, | |||
There was a problem hiding this comment.
We still need to test lower case though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #1807, credit to @funderscore1